Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make quickFilters compatible with Thunderbird 91 #48

Closed
RealRaven2000 opened this issue Feb 19, 2021 · 17 comments
Closed

Make quickFilters compatible with Thunderbird 91 #48

RealRaven2000 opened this issue Feb 19, 2021 · 17 comments
Assignees
Labels
bug e10s Multi-process browsing

Comments

@RealRaven2000
Copy link
Owner

Thunderbird 86 introduced multi-process browsing (e10s a.k.a. electrolysis) which creates some compatibility issues with some functions.

Quick patch version for 86.0b3:
quickFilters-wx-5.2pre6.zip

To install, download the xip file and drag into Thunderbird Add-ons Manager.

Ongoing bugfixes for beta versions will go here.

@RealRaven2000 RealRaven2000 added bug e10s Multi-process browsing labels Feb 19, 2021
@RealRaven2000
Copy link
Owner Author

Importing filters and filter trouble shooter wasn't working. Also any filters that have no search condition at all will disrupt the troubleshooting process.

Patched version:
quickFilters-wx-5.2pre20.zip

@RealRaven2000 RealRaven2000 self-assigned this Feb 20, 2021
@aprojanos71
Copy link

Super!
It works! I see the names of the faulty filters and the backup also works fine.
Thx!

@aprojanos71
Copy link

Merge does not work ...

@RealRaven2000
Copy link
Owner Author

Merge does not work ...

thanks for finally using github for bug reporting. What exactly doesn't work - how do you invoke it?

When you merge filters they have to have the same (main) action - e.g. move mails to the same folder.
You can select 2 filters with the same action and do merge manually or you are prompted to merge when you add new condition to an existing filter - e,g, dropping an email to a folder that already has filters addressing it.

@RealRaven2000
Copy link
Owner Author

I tested in Tb86.0b3 with the assistant (assistant is active, I already had a filter that moves mail to pinterest) I moved a mail to the folder "pinterest" and it came up with the merge suggestion for the existing filter. I was able to successfully merge in the condition "recommendations@explore.pinterest.com" which was not pre-existing in the filter. (the condition with @pinterest already existed)

image

image

@aprojanos71
Copy link

When I select two filters and want to merge, it does nothing.
The two filters do the same thing - [move to spam] - but do nothing.

Uncaught TypeError: stCollection.Count is not a function qFilters-utils.js:1236:63
copyTerms chrome://quickfilters/content/qFilters-utils.js:1236
merge chrome://quickfilters/content/qFilters-list.js:423
oncommand chrome://messenger/content/FilterListDialog.xhtml:1
[Learn More]
copyTerms chrome://quickfilters/content/qFilters-utils.js:1236
merge chrome://quickfilters/content/qFilters-list.js:423
oncommand chrome://messenger/content/FilterListDialog.xhtml:1

@aprojanos71
Copy link

ScreenShot098

@RealRaven2000
Copy link
Owner Author

Try this version:

quickFilters-wx-5.2pre24.zip

There was another instance of searchTerms.Count() which is not supported in Thunderbird 86, I think they changed the type of the searchTerms attribute from nsIMutableArray to an Array<nsIMsgSearchTerm>. See code:
comm-esr78
comm-central

Still a side effect from not using APIs I think changes like these will be even more frequent this year:

https://bugzilla.mozilla.org/show_bug.cgi?id=857230

@aprojanos71
Copy link

Yes, it works!
Thx!

@RealRaven2000 RealRaven2000 changed the title Make quickFilters compatible with TB86 beta Make quickFilters compatible with TB88 beta Mar 31, 2021
@RealRaven2000
Copy link
Owner Author

Here is the latest version which can run on Thunderbird 88.0b1 - note that the new "sort search terms" feature in the filter editor is still experimental!

quickFilters-wx-5.2pre59.zip

Install by downloading the zip file and then dropping it into Thunderbird Add-ons Manager. Compatible from Thunderbird 78 forward. I had to drop the strict_max_version for now, because 88.0 isn't yet listed as valid version but absolutely no guarantees for running it in 89 or higher!!

@RealRaven2000
Copy link
Owner Author

Latest version, including the "Sort search terms" feature on the edit filter dialog:

quickFilters-wx-5.2pre72.zip

Install by downloading the zip file and then dropping it into Thunderbird Add-ons Manager. Compatible from Thunderbird 78 forward.

@RealRaven2000 RealRaven2000 changed the title Make quickFilters compatible with TB88 beta Make quickFilters compatible with TB91 beta Jul 18, 2021
@RealRaven2000
Copy link
Owner Author

Problem on the support tab in Thunderbird 91.0b1 with descriptions for the buttons "sliding down" to the bottom:
image

Also, when trying to open the debug settings via right-click, the about:config panel is not opened anymore:
image

@RealRaven2000
Copy link
Owner Author

Latest version see below
Changes:

quickFilters-wx-5.3pre136.zip

To install, download the zip file and then drag that file into Thunderbird Add-ons Manager.

@RealRaven2000
Copy link
Owner Author

RealRaven2000 commented Jul 29, 2021

Latest version see below
Changes:

  • fixed layout on the Support tab and added a button to Display the Splash Screen at any time
  • removed use of fixIterator (deprecated function in Tb91) from findInboxFromRoot() function.
  • removed legacy code for displaying version number in options / update check
  • slight layout changes in update splash screen
  • removed links to mozdev.org for legacy bugs

quickFilters-wx-5.3pre154.zip

To install, download the zip file and then drag that file into Thunderbird Add-ons Manager.

@RealRaven2000
Copy link
Owner Author

Latest Version
Changes:

  • Restricted special search types in filter list to licensed users
  • Fixed style of [Buy License] button at bottom of settings dialog
  • Fixed icons in sliding notifications
  • Fixed missing "about:config" dialogs

quickFilters-wx-5.3pre167.zip

To install, download the zip file and then drag that file into Thunderbird Add-ons Manager.

@RealRaven2000
Copy link
Owner Author

I uploaded a new release to ATN this morning, see https://github.com/RealRaven2000/quickFilters/releases/tag/5.3.1
In this one, I do not set strict_max_version (mainly because there are no "legal" values greater than 91.0a1 available to the current validator) - I only have tested it as far as the current 92 daily. But it should be fully compatible with 91.0 ESR as far as I can tell. Leaving this issue open for Tb91 related regressions until the majority of users are migrated to it.

I also finally created the product for a quickFilters domain license on the fastspring shop. I just need to add the decryption keys for domain licenses in the next quickFilters release

@RealRaven2000 RealRaven2000 changed the title Make quickFilters compatible with TB91 beta Make quickFilters compatible with Thunderbird 91 Aug 5, 2021
@RealRaven2000
Copy link
Owner Author

Closing this bug now as we move on into the phase of using more official API technology and slowly replacing experimental APIs where possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug e10s Multi-process browsing
Projects
None yet
Development

No branches or pull requests

2 participants