Promote: staging -> develop#700
Merged
Merged
Conversation
fix(android): track Fastlane Gemfile.lock to fix android-deploy
…ge (#699) ## Problem When buying/selling RealUnit while the external price provider (Aktionariat) is down, the app showed a generic "An error occurred … contact support" message. That wrongly implies the problem is with RealUnit or the app, when it is the external price provider. ## Change Pairs with API PR DFXswiss/api#3825, which now returns `503` / `code: PRICE_SOURCE_UNAVAILABLE` for the buy/sell quote during a price-source outage. - New `PaymentInfoError.priceSourceUnavailable`. - Buy (`buy_payment_info_cubit.dart`) and sell (`sell_payment_info_cubit.dart`): add an `on ApiException` clause — matched on `statusCode == 503` **or** `code == 'PRICE_SOURCE_UNAVAILABLE'` — kept **below** the KYC/Registration clauses (those are `ApiException` subclasses). Matching on both makes it defensive even before the API ships. - Render an explicit message attributing the problem to Aktionariat: buy shows it inline (`payment_information.dart`), sell shows it as a snackbar (`sell_button.dart`). - New i18n keys `priceProviderUnavailableTitle` / `priceProviderUnavailableDescription` (de + en). Dashboard intentionally unchanged (still `--.--`) — scope is buy/sell only. ## Copy (de) > **Problem beim Kursanbieter (Aktionariat)** > Der externe Kursanbieter Aktionariat liefert aktuell keine Kurse. Das Problem liegt bei Aktionariat – nicht bei RealUnit oder der App. Sobald Aktionariat wieder Kurse liefert, funktioniert alles automatisch. Bitte später erneut versuchen. ## Tests - Buy + sell payment-info cubit tests: `503` and `code` → `priceSourceUnavailable`; other `ApiException` → `unknown`. - New buy golden `buy_price_source_unavailable` (regenerated via `golden-regenerate.yaml`). - `flutter analyze` clean; buy/sell cubit suites green. ## Test plan - [ ] Buy/sell while the price source is down (current real state) → explicit Aktionariat message, not the generic one. - [ ] Normal case (price available) → unchanged. --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic Staging PR
This PR was automatically created after changes were pushed to staging.
Commits: 1 new commit(s)
Checklist