revert(buy): restore "click after transfer" payment-confirm label (#661)#703
Merged
Conversation
Reverts #661 (issue #660). The relabel to "Request payment instructions by email" contradicts the screen it lives on: the payment information (IBAN, BIC, address, QR code) is already rendered above the button, and buyPaymentInformationDescription explicitly tells the user to transfer the amount now. After the tap, PaymentExecutedSheet says "as soon as your transfer has been received, we will transfer the REALU tokens". The button's onPressed calls confirmPayment() -> PUT /v1/realunit/buy/{id}/confirm, which confirms the order and returns a reference. It does not request payment instructions by email, and the instructions are not delivered by email at all — they are on screen. The original label "Click here once you have made the transfer" / "Klicken Sie hier, sobald Sie die Überweisung getätigt haben" is consistent with both the description above and the executed sheet below. Reverts commit 1a659e7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #661 (issue #660).
The bug
#661 relabelled the buy-payment button
buyPaymentConfirmfrom "Click here once you have made the transfer" to "Request payment instructions by email" / "Zahlungsanweisungen per E-Mail anfordern", on the premise that the click requests the payment slip by email and the customer pays afterwards.That premise is wrong. On the screen where this button lives (
PaymentInformationDetails):buyPaymentInformationDescription(above)PaymentExecutedSheet(after tap)The button's
onPressedcallsconfirmPayment()→PUT /v1/realunit/buy/{id}/confirm, which confirms the order and returns a reference. It does not email any instructions, and the instructions are not delivered by email — they are rendered on the same screen. The new label therefore contradicts both the description above it and the success sheet below it, and mislabels a confirm action as an info request.The fix
Full revert of #661. Restores the original label, which is consistent with the surrounding copy and the actual
/confirmbehaviour:Klicken Sie hier, sobald Sie die Überweisung getätigt habenClick here once you have made the transferScope
buyPaymentConfirmvalue instrings_de.arb+strings_en.arb(key position unchanged, no other keys touched).home_page_loaded.pnggolden that #661 had bundled in. Goldens are regenerated authoritatively on the dfx01 runner viagolden-regenerate.yamlafter push (thebuy_payment_info_loadedgolden must pick up the restored label).lib/generated/i18n.dartis git-ignored and regenerated in CI.Draft until regenerated goldens land and CI (Analyze & Test + Visual Regression + Coverage Floor) is green.