From 3bcc6cc7cd65c4a82ebca3bc8c274c46c7c79198 Mon Sep 17 00:00:00 2001 From: Cory Pride Date: Fri, 17 May 2024 10:00:20 -0500 Subject: [PATCH] renamed editModeAndTypeUpdate function to resetEditModeTypeStates and moved some of its functionality to a new function called validateUpdateEmailErrorStates on the AccountSettings page --- .../components/Settings/AccountSettings.tsx | 23 ++++++++++--------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/publisher/src/components/Settings/AccountSettings.tsx b/publisher/src/components/Settings/AccountSettings.tsx index 038889a3d..360fd2b41 100644 --- a/publisher/src/components/Settings/AccountSettings.tsx +++ b/publisher/src/components/Settings/AccountSettings.tsx @@ -43,33 +43,34 @@ export const AccountSettings = () => { const [name, setName] = React.useState(userStore?.name || ""); const [isSettingInEditMode, setIsSettingInEditMode] = React.useState(false); - const [editType, setEditType] = React.useState(""); + const [editType, setEditType] = React.useState(undefined); const [isEmailValid, setIsEmailValid] = React.useState(true); const [errorMsg, setErrorMsg] = React.useState< { message: string } | undefined >(undefined); const onClickClose = () => { setEmail(userStore?.email || ""); - editModeAndTypeUpdate(); + resetEditModeTypeStates(); setName(userStore?.name || ""); setIsSettingInEditMode(false); }; - const editModeAndTypeUpdate = () => { - setIsSettingInEditMode(!isSettingInEditMode); - if (editType === EditType.Email_edit) { - setIsEmailValid(true); - setErrorMsg(undefined); - } - setEditType(""); + const resetEditModeTypeStates = () => { + setIsSettingInEditMode(false); + setEditType(undefined); + }; + const validateUpdateEmailErrorStates = () => { + setIsEmailValid(true); + setErrorMsg(undefined); }; const saveNameEmailChange = (nameUpdate?: string, emailUpdate?: string) => { if (nameUpdate) { - editModeAndTypeUpdate(); + resetEditModeTypeStates(); return userStore.updateUserNameAndEmail(nameUpdate, email); } if (emailUpdate) { if (validateEmail(emailUpdate)) { - editModeAndTypeUpdate(); + validateUpdateEmailErrorStates(); + resetEditModeTypeStates(); return userStore.updateUserNameAndEmail(name, emailUpdate); } setErrorMsg({ message: "Invalid Email" });