Skip to content

Make GenericWriterPostProcessor validate its input, and not leak an open file if parsing an FLV fails #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2025
Merged

Make GenericWriterPostProcessor validate its input, and not leak an open file if parsing an FLV fails #402

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions io/src/main/java/org/red5/media/processor/GenericWriterPostProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,19 @@ public class GenericWriterPostProcessor implements IPostProcessor {
public void init(Object... objs) {
log.info("init: {}", Arrays.toString(objs));
// we expect a file path to which a writer wrote to
file = new File(objs[0].toString());
if (objs != null && objs.length > 0 && objs[0] != null) {
file = new File(objs[0].toString());
} else {
log.warn("Init called without a valid file reference");
file = null;
}
}

/** {@inheritDoc} */
@Override
public void run() {
if (file != null) {
try {
FLVReader reader = new FLVReader(file);
try (FLVReader reader = new FLVReader(file)) {
ITag tag = null;
int audio = 0, video = 0, meta = 0;
while (reader.hasMoreTags()) {
Expand All @@ -59,7 +63,6 @@ public void run() {
}
}
}
reader.close();
log.info("Data type counts - audio: {} video: {} metadata: {}", audio, video, meta);
} catch (Exception e) {
log.error("Exception reading: {}", file.getName(), e);
Expand Down