Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] <footer> UX footer demo not rendering icons or rh-cta #613

Closed
heyMP opened this issue Nov 2, 2022 · 3 comments · Fixed by #694
Closed

[bug] <footer> UX footer demo not rendering icons or rh-cta #613

heyMP opened this issue Nov 2, 2022 · 3 comments · Fixed by #694
Assignees
Labels
bug Something isn't working for dev Ready for development priority: high High priority

Comments

@heyMP
Copy link
Member

heyMP commented Nov 2, 2022

Describe the bug

There are two issues on the footer demo page.

  1. pfe-icons are failing to load.
  2. rh-cta for the "Sign up now" button not being loaded.

Which Component?

rh-footer

Steps to reproduce

  1. Go to https://ux.redhat.com/components/footer/demo/
  2. Verify that the social icons in the top right corner are not being rendered correctly
  3. Verify that the "Sign up now" cta is being rendered as a standard link and not an rh-cta

Expected behaviour

pfe-icon and rh-cta should be configured properly.

Screenshots

Screenshot 2022-11-02 at 4 17 50 PM

Illustrating how pfe-icon is trying to load the icons from jspm
Screenshot 2022-11-02 at 4 12 29 PM

Element HTML

No response

Operating System (OS)

macOS

Browser

Chrome

More browser information

No response

Additional Info

No response

@heyMP heyMP added bug Something isn't working for dev Ready for development labels Nov 2, 2022
@bennypowers
Copy link
Member

@heyMP heyMP changed the title [bug] UX footer demo not rendering icons or rh-cta [bug] <footer> UX footer demo not rendering icons or rh-cta Nov 15, 2022
@paigenotfound404 paigenotfound404 added the priority: high High priority label Nov 28, 2022
@coreyvickery
Copy link
Collaborator

@heyMP Status of this?

@heyMP
Copy link
Member Author

heyMP commented Jan 9, 2023

@coreyvickery This is still an issue, we have to update the import map for pfe-icon on the demo page and we should be good to go. Thanks for the ping!


We need to add a pfe-icon/
The import map has pfe-icon but it needs pfe-icon/ to get the contents.

@bennypowers bennypowers linked a pull request Jan 9, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working for dev Ready for development priority: high High priority
Projects
Status: Done ☑️
Development

Successfully merging a pull request may close this issue.

4 participants