Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Cannot read properties of undefined (reading 'invoker') floating-com-controller.js #701

Closed
heyMP opened this issue Jan 12, 2023 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@heyMP
Copy link
Member

heyMP commented Jan 12, 2023

Describe the bug

Description of the issue

We're seeing an error with the floating-dom-controller on sites that are using the latest version of rh-tooltip.

@rhds/elements@1.0.0-beta.27

Which Component?

rh-tooltip

Steps to reproduce

  1. Go to https://deploy-preview-55--red-hat-design-tokens.netlify.app/
  2. Open console and see the following error

Screenshot 2023-01-12 at 12 21 05 PM

@heyMP heyMP added the bug Something isn't working label Jan 12, 2023
@bennypowers
Copy link
Member

we have this same problem on the tokens site

can you take a look @brianferry ?

@brianferry brianferry self-assigned this Jan 12, 2023
@brianferry
Copy link
Collaborator

Sure thing @bennypowers

@brianferry
Copy link
Collaborator

I'm thinking this is caused by pfe-core being published with the floating-ui floating-dom-controller but the version of rh-tooltip with it updated to the new library has not yet being published.

Version Beta.27 of the tooltip still uses popper but Beta.28 does not, my demo here https://codepen.io/OhHeyBrian/pen/dyjRbWz shows Beta.27 working with Popper and 1 version back on pfe-core being used.

JSPM is bringing in the latest version of core automatically so while it is bringing in the floating-ui libraries it does not have the latest code that uses it for tooltip yet.

@bennypowers
Copy link
Member

JSPM has a way to specify fixes for versions broken this way

https://github.com/jspm/overrides

If we publish and update all the dependencies, that should fix the next version

@heyMP
Copy link
Member Author

heyMP commented Jan 16, 2023

Added this to our wiki: https://github.com/RedHat-UX/red-hat-design-system/wiki/JSPM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants