Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] rh-footer doesn't support rh-accordion #707

Closed
heyMP opened this issue Jan 18, 2023 · 2 comments · Fixed by #742
Closed

[bug] rh-footer doesn't support rh-accordion #707

heyMP opened this issue Jan 18, 2023 · 2 comments · Fixed by #742
Assignees
@heyMP
Labels
bug Something isn't working for dev Ready for development priority: high High priority

Comments

@heyMP
Copy link
Member

heyMP commented Jan 18, 2023 •
edited

Describe the bug

The footer demo is currently not rendering the mobile links accordion dropdown correctly. This is because rh-footer only supports pfe-accordion 1.x. We should add styles to also support pfe-accordion 2.x rh-accordion.

Which Component?

rh-footer

Steps to reproduce

  1. Go to https://ux.redhat.com/components/footer/demo/
  2. Shrink the browser window below 990px
  3. The primary links should now be in a pfe-accordion dropdown
  4. Compare that with the rh-footer on https://redhat.com

Expected behaviour

We should replace pfe-accordion with rh-accordion

Screenshots

Screenshot 2023-01-18 at 9 33 32 AM

Element HTML

No response

Operating System (OS)

macOS

Browser

Chrome

More browser information

No response

Additional Info

No response
@heyMP heyMP added the bug Something isn't working label Jan 18, 2023
@bennypowers
Copy link
Member

bennypowers commented Jan 18, 2023 •
edited

we released rh-accordion, much better to nuke pfe-accordion, no?

@heyMP
Copy link
Member Author

heyMP commented Jan 18, 2023

Oh, yes. Good call! I'll update this issue.

@heyMP heyMP changed the title [bug] rh-footer doesn't support pfe-accordion 2.x [bug] rh-footer doesn't support rh-accordion Jan 18, 2023
@heyMP heyMP added the for dev Ready for development label Feb 7, 2023
@heyMP heyMP added the priority: high High priority label Feb 17, 2023
@heyMP heyMP assigned heyMP and unassigned heyMP Feb 17, 2023
@heyMP heyMP linked a pull request Feb 20, 2023 that will close this issue
fix(footer): accordion styles at mobile screen sizes #742
Merged
@github-actions github-actions bot mentioned this issue Feb 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heyMP heyMP

Labels
bug Something isn't working for dev Ready for development priority: high High priority
Projects
Red Hat Design System
Status: Done ☑️
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(footer): accordion styles at mobile screen sizes RedHat-UX/red-hat-design-system
3 participants
@bennypowers @heyMP @coreyvickery