Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): remove spinner demo page from ux.redhat.com #674

Merged
merged 17 commits into from Jan 6, 2023

Conversation

marionnegp
Copy link
Collaborator

What I did

  1. Deleted Spinner page from the Component section.

Testing Instructions

  1. Check that Spinner doesn't show up in the deploy preview link. The Component nav should look like this:

Screen Shot 2022-12-14 at 5 31 49 PM

Notes to Reviewers

@marionnegp marionnegp added bug Something isn't working docs Improvements or additions to documentation labels Dec 14, 2022
@marionnegp marionnegp self-assigned this Dec 14, 2022
@changeset-bot
Copy link

changeset-bot bot commented Dec 14, 2022

🦋 Changeset detected

Latest commit: 40aa8df

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@rhds/elements Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Dec 14, 2022

Deploy Preview for red-hat-design-system ready!

Name Link
🔨 Latest commit 40aa8df
🔍 Latest deploy log https://app.netlify.com/sites/red-hat-design-system/deploys/63b888e85a345f00083d1947
😎 Deploy Preview https://deploy-preview-674--red-hat-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@marionnegp
Copy link
Collaborator Author

@bennypowers, do you know why the Netlify deploy log is still showing after rh-badge merged?

Screen Shot 2022-12-14 at 5 50 12 PM

@marionnegp marionnegp marked this pull request as ready for review December 19, 2022 18:23
@marionnegp marionnegp marked this pull request as draft December 19, 2022 18:43
@bennypowers
Copy link
Member

Failing because of #681 (comment)

@bennypowers bennypowers marked this pull request as ready for review December 22, 2022 20:00
@bennypowers bennypowers enabled auto-merge (squash) December 29, 2022 16:00
@bennypowers
Copy link
Member

@bennypowers bennypowers merged commit 41e27dd into main Jan 6, 2023
@bennypowers bennypowers deleted the fix/remove-spinner-page branch January 6, 2023 20:53
nikkimk pushed a commit that referenced this pull request Jan 9, 2023
* fix(docs): removed spinner demo page from ux dot nav

* docs(spinner): update package-lock

* fix(docs): update package-lock and node modules

* test(tag): don't test shadow dom

* perf(tag): optimize css

* fix(tag): implement abstract props

Co-authored-by: Michael Potter <mgp140@gmail.com>
Co-authored-by: Benny Powers <web@bennypowers.com>
nikkimk pushed a commit that referenced this pull request Jan 23, 2023
* fix(docs): removed spinner demo page from ux dot nav

* docs(spinner): update package-lock

* fix(docs): update package-lock and node modules

* test(tag): don't test shadow dom

* perf(tag): optimize css

* fix(tag): implement abstract props

Co-authored-by: Michael Potter <mgp140@gmail.com>
Co-authored-by: Benny Powers <web@bennypowers.com>
nikkimk pushed a commit that referenced this pull request Jan 23, 2023
* fix(docs): removed spinner demo page from ux dot nav

* docs(spinner): update package-lock

* fix(docs): update package-lock and node modules

* test(tag): don't test shadow dom

* perf(tag): optimize css

* fix(tag): implement abstract props

Co-authored-by: Michael Potter <mgp140@gmail.com>
Co-authored-by: Benny Powers <web@bennypowers.com>
nikkimk pushed a commit that referenced this pull request Jan 24, 2023
* fix(docs): removed spinner demo page from ux dot nav

* docs(spinner): update package-lock

* fix(docs): update package-lock and node modules

* test(tag): don't test shadow dom

* perf(tag): optimize css

* fix(tag): implement abstract props

Co-authored-by: Michael Potter <mgp140@gmail.com>
Co-authored-by: Benny Powers <web@bennypowers.com>
nikkimk pushed a commit that referenced this pull request Jan 24, 2023
* fix(docs): removed spinner demo page from ux dot nav

* docs(spinner): update package-lock

* fix(docs): update package-lock and node modules

* test(tag): don't test shadow dom

* perf(tag): optimize css

* fix(tag): implement abstract props

Co-authored-by: Michael Potter <mgp140@gmail.com>
Co-authored-by: Benny Powers <web@bennypowers.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs Improvements or additions to documentation
Projects
Status: Done ☑️
Development

Successfully merging this pull request may close these issues.

None yet

5 participants