doc: adding event listener example to rh-alert #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Deploy Preview for red-hat-design-system ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
bennypowers
requested changes
Jan 3, 2023
bennypowers
reviewed
Jan 3, 2023
bennypowers
reviewed
Jan 5, 2023
bennypowers
approved these changes
Jan 14, 2023
nikkimk
pushed a commit
that referenced
this pull request
Jan 23, 2023
* doc: adding event listener example to rh-alert * doc: rh-alert event listener documentation reasoning * fix(alert): remove state switching to error after element is removed * docs(alert): adding section for preventing default close behavior to readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had discussed sometime back about adding documentation to the
rh-alertREADME outlining how you could add your own custom event handler forrh-alerton acloseevent. This is adding that code as well as a reasoning behind why you would use this.