fix(footer): fix demo icons #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9e36c21 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for red-hat-design-system ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
heyMP
reviewed
Jan 11, 2023
heyMP
reviewed
Jan 11, 2023
|
@heyMP I'm not sure what else we need to do here |
|
@bennypowers I was seeing if you were cool with keeping a deprecated css property to support our current sites. I'll merge it and if we have any concerns we can come back later. |
|
yeah that's fine by me |
nikkimk
pushed a commit
that referenced
this pull request
Jan 23, 2023
* docs(footer): fix demo icons * chore: revert previous * docs(footer): fix icons in demo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
import all thefabicons into the importMap for 11ty (should really only be done on footer pages)--pfe-icon--colorin favor of using slotted selector to support pfe-icon 2.0Testing Instructions
dp/components/footer/demo/Screenshot
Notes to Reviewers
don't look too closely into this one ;)nvm this is pure 🔥this should be reverted in favour of
<rh-icon>, when it's ready