fix(tooltip): remove on attribute
#702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9f1ffaa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for red-hat-design-system ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
bennypowers
changed the title
on attributeon attribute
bennypowers
requested changes
Jan 14, 2023
bennypowers
approved these changes
Jan 14, 2023
nikkimk
pushed a commit
that referenced
this pull request
Jan 23, 2023
* fix(tooltip): making on property private, adding wrapper to render, css for wrapper * chore(tooltip): fixing whitespace * chore: adding changeset * fix(tooltip): removing position test as it tests the shadow dom * docs: update changeset Co-authored-by: Benny Powers <bennypowers@users.noreply.github.com>
nikkimk
pushed a commit
that referenced
this pull request
Jan 24, 2023
* fix(tooltip): making on property private, adding wrapper to render, css for wrapper * chore(tooltip): fixing whitespace * chore: adding changeset * fix(tooltip): removing position test as it tests the shadow dom * docs: update changeset Co-authored-by: Benny Powers <bennypowers@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
onattribute inrh-tooltip.rh-tooltipwhich provides the context styling for the shadow dom.Testing Instructions