Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace SCP info with working payload download button #38

Merged
merged 6 commits into from Feb 4, 2020

Conversation

@mturley
Copy link
Collaborator

mturley commented Feb 3, 2020

https://bugzilla.redhat.com/show_bug.cgi?id=1788730
https://issues.redhat.com/browse/MIGENG-241
Closes #19

Depends on #37 and ManageIQ/manageiq-ui-classic#6645

When the download button is clicked, the payload contents are loaded into memory via the MIQ API, then the data is saved to a file via browser APIs.

Since the actual download happens before the browser starts writing to a file, no progress is reported in the browser's download manager. Instead, you'll see a spinner on the page for a moment followed by what seems like an instant download.

rLakHe98r8

@miq-bot

This comment has been minimized.

Copy link

miq-bot commented Feb 3, 2020

Checked commits mturley/cfme-migration_analytics@0f2e4f2~...fb2a21c with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@mzazrivec mzazrivec self-assigned this Feb 4, 2020
@mzazrivec mzazrivec merged commit 14f92e5 into RedHatCloudForms:master Feb 4, 2020
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@mturley mturley deleted the mturley:payload-download-button branch Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.