Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes RHICOMPL-223: Handle errored remediations #69

Merged
merged 1 commit into from Jul 3, 2019
Merged

Fixes RHICOMPL-223: Handle errored remediations #69

merged 1 commit into from Jul 3, 2019

Conversation

akofink
Copy link
Contributor

@akofink akofink commented Jul 2, 2019

If the remediations API fails for whatever reason, we should handle it
as gracefully as possible in the system details rules table.

If the remediations API is down, the table will just show that no remediation is available. I think this is fine, because the remediation isn't available at this time, at least.

Signed-off-by: Andrew Kofink akofink@redhat.com

@akofink akofink requested a review from dLobatog July 2, 2019 17:01
@codecov-io
Copy link

Codecov Report

Merging #69 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #69   +/-   ##
=======================================
  Coverage   27.33%   27.33%           
=======================================
  Files         135      135           
  Lines        2049     2049           
  Branches      364      364           
=======================================
  Hits          560      560           
  Misses       1210     1210           
  Partials      279      279
Impacted Files Coverage Δ
...kages/inventory-compliance/src/SystemRulesTable.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2f3e99...dbda1b5. Read the comment docs.

dLobatog
dLobatog previously approved these changes Jul 3, 2019
Copy link
Contributor

@dLobatog dLobatog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks simple enough and I can reproduce the behavior, let's make a release with this + the previous change 😄 thanks @akofink

If the remediations API fails for whatever reason, we should handle it
as gracefully as possible in the system details rules table.

Signed-off-by: Andrew Kofink <akofink@redhat.com>
@akofink
Copy link
Contributor Author

akofink commented Jul 3, 2019

Rebased

@dLobatog dLobatog merged commit 7dfe6d0 into RedHatInsights:master Jul 3, 2019
@akofink akofink deleted the RHICOMPL-223 branch July 3, 2019 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants