fix(test): remove workaround for multi-user UI tests#1630
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1630 +/- ##
=======================================
Coverage 77.58% 77.58%
=======================================
Files 103 103
Lines 3266 3266
Branches 729 729
=======================================
Hits 2534 2534
Misses 655 655
Partials 77 77 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
xbhouse
force-pushed
the
remove-test-workaround
branch
from
5bc177a to
703b408
Compare
This reverts the workaround we had that split users into different UI projects to prevent auth state conflicts. The conflicts were caused by the frontend-development-proxy caching parallel responses by URL, and this has been fixed.
swadeley
force-pushed
the
remove-test-workaround
branch
from
703b408 to
f76c46d
Compare
Collaborator
Author
|
merging, ui test failures are unrelated, i'm looking into those here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
How to test the PR
UI tests pass with no auth-related failures