Expand contents of SecurityContextConstraints #1229
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Report bugs in Issues The following are automatically added:
Available user actions:
Supported labels
|
rnetser
requested changes
May 31, 2023
| Security Context Constraints object. API reference: | ||
| https://docs.openshift.com/container-platform/4.13/rest_api/security_apis/securitycontextconstraints-security-openshift-io-v1.html | ||
| Args: |
Collaborator
There was a problem hiding this comment.
- should be under init
- do not repeat the api docs
- defaults by the api should not appear here
| super().to_dict() | ||
| if not self.yaml_file: | ||
| self.res.update() | ||
| manifest_spec = self.res |
for more information, see https://pre-commit.ci
|
Kudos, SonarCloud Quality Gate passed!
|
myakove
approved these changes
Jun 5, 2023
rnetser
requested changes
Jun 9, 2023
| https://docs.openshift.com/container-platform/4.13/rest_api/security_apis/securitycontextconstraints-security-openshift-io-v1.html | ||
| Args: | ||
| allow_host_dir_volume_plugin (bool): Determines if the policy allow containers to use the HostDir volume |
Collaborator
There was a problem hiding this comment.
please add defaults, e.g allow_host_dir_volume_plugin (bool, default: False)
| if self.groups: | ||
| self.res["groups"] = self.groups | ||
|
|
||
| if self.priority: |
Collaborator
There was a problem hiding this comment.
priority default is 0
is 0 a valid option?if so, the code below will not be reached
redhat-qe-bot
added
Changes_Requested-by-rnetser
needs-rebase
and removed
needs-rebase
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support extra parameters of SecurityContextConstraints resource.