Skip to content

Add new resource: VirtualMachineClone #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2023
Merged

Add new resource: VirtualMachineClone #1324

merged 1 commit into from
Jul 31, 2023

Conversation

@dshchedr
Copy link
Contributor

@dshchedr dshchedr commented Jul 28, 2023

Short description:

Add new resource: VirtualMachineClone

More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
Bug:

@redhat-qe-bot
Copy link
Contributor

redhat-qe-bot commented Jul 28, 2023

Report bugs in Issues

The following are automatically added:

  • Add reviewers from OWNER file (in the root of the repository) under reviewers section.
  • Set PR size label.
  • New issue is created for the PR. (Closed when PR is merged/closed)
  • Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
    • Multiple target branches can be cherry-picked, separated by spaces.
    • Cherry-pick will be started when PR is merged
  • To re-run tox comment /retest tox in the PR.
  • To re-run build-container command /retest build-container in the PR.
  • To re-run python-module-install command /retest python-module-install in the PR.
  • To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
  • To add a label by comment use /<label name>, to remove, use /<label name> cancel
Supported labels
  • hold
  • verified
  • wip
  • lgtm
  • approve

@dshchedr
Copy link
Contributor Author

dshchedr commented Jul 28, 2023

/verified

myakove
myakove requested changes Jul 28, 2023
View reviewed changes
Copy link
Collaborator

@myakove myakove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a link to the resource API at the top of the file

@myakove
Copy link
Collaborator

myakove commented Jul 28, 2023

For which version VirtualMachineClone resource is targeted?

@dshchedr dshchedr force-pushed the add_virtual_machine_clone_object branch from 0930bc1 to a95cf4b Compare July 28, 2023 23:52
@redhat-qe-bot redhat-qe-bot requested a review from myakove July 28, 2023 23:53
@dshchedr
Copy link
Contributor Author

dshchedr commented Jul 29, 2023 •
edited
Loading

Please add a link to the resource API at the top of the file
For which version VirtualMachineClone resource is targeted?

It is already implemented in 4.14, but GA is planned in 4.15
no any openshift docs for the reference yet

myakove
myakove requested changes Jul 29, 2023
View reviewed changes
Copy link
Collaborator

@myakove myakove left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add TODO to add a link to the resource API at the top of the file

@myakove
Copy link
Collaborator

myakove commented Jul 29, 2023

/cherry-pick v4.14

@redhat-qe-bot
Copy link
Contributor

redhat-qe-bot commented Jul 29, 2023

Cherry-pick requested for PR: Add new resource: VirtualMachineClone by user myakove
Adding label/s cherry-pick-v4.14 for automatic cheery-pick once the PR is merged

rnetser
rnetser requested changes Jul 29, 2023
View reviewed changes
@dshchedr dshchedr force-pushed the add_virtual_machine_clone_object branch from a95cf4b to 7e95bf5 Compare July 30, 2023 00:45
@redhat-qe-bot redhat-qe-bot requested review from myakove and rnetser July 30, 2023 00:45
myakove
myakove requested changes Jul 30, 2023
View reviewed changes
@dshchedr dshchedr force-pushed the add_virtual_machine_clone_object branch from 7e95bf5 to 072c9cf Compare July 31, 2023 13:27
@redhat-qe-bot redhat-qe-bot requested a review from myakove July 31, 2023 13:28
@dshchedr
Copy link
Contributor Author

dshchedr commented Jul 31, 2023

/verified

@rnetser rnetser merged commit ee189bc into RedHatQE:main Jul 31, 2023
redhat-qe-bot pushed a commit that referenced this pull request Jul 31, 2023
@dshchedr
Add new resource: VirtualMachineClone (#1324)
daceebf
@redhat-qe-bot redhat-qe-bot mentioned this pull request Jul 31, 2023
Merged
@redhat-qe-bot
Copy link
Contributor

redhat-qe-bot commented Jul 31, 2023

Cherry-picked PR Add new resource: VirtualMachineClone into v4.14

redhat-qe-bot added a commit that referenced this pull request Jul 31, 2023
@redhat-qe-bot @dshchedr
Add new resource: VirtualMachineClone (#1324) (#1326)
f3c2070 
Co-authored-by: Den <dshchedr@redhat.com>
myakove pushed a commit that referenced this pull request Aug 11, 2025
@dshchedr
Add new resource: VirtualMachineClone (#1324)
a09c86c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@myakove myakove myakove approved these changes

@rnetser rnetser rnetser approved these changes

@omrirh omrirh Awaiting requested review from omrirh

@oharan2 oharan2 Awaiting requested review from oharan2

Assignees

@dshchedr dshchedr

Labels

ApprovedBy-myakove ApprovedBy-rnetser branch-main cherry-pick-v4.14 CommentedBy-dshchedr size/M verified

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dshchedr @redhat-qe-bot @myakove @rnetser