Skip to content

add more logging to vmi.wait_until_running() #1352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 14, 2023
Merged

add more logging to vmi.wait_until_running() #1352

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7628538
add more logging to vmi.wait_until_running()
vsibirsk Aug 9, 2023
3cad86b
add vmi.name to log msg
vsibirsk Aug 10, 2023
c5c47b5
add vm property and vm status to logs
vsibirsk Aug 10, 2023
d4df8a7
add raise exception if vm not found
vsibirsk Aug 10, 2023
f99ab7f
Remove VM object refs
vsibirsk Aug 14, 2023
9cc54a3
Merge branch 'main' into update-vmi-wait-running
myakove Aug 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ocp_resources/virtual_machine_instance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,15 +115,21 @@ def wait_until_running(self, timeout=TIMEOUT_4MINUTES, logs=True, stop_status=No
TimeoutExpiredError: If VMI failed to run.
"""
try:
self.logger.info(
f"VMI {self.name} status before wait: {self.instance.status.phase}"
)
self.wait_for_status(
status=self.Status.RUNNING, timeout=timeout, stop_status=stop_status
)
except TimeoutExpiredError:
if not logs:
raise

self.logger.error(f"VMI {self.name} status: {self.instance.status.phase}")
virt_pod = self.virt_launcher_pod
if virt_pod:
self.logger.error(
f"Status of virt-launcher pod {virt_pod.name}: {virt_pod.status}"
)
self.logger.debug(f"{virt_pod.name} *****LOGS*****")
self.logger.debug(virt_pod.log(container="compute"))

Expand Down