Skip to content

Conversation

@myakove
Copy link
Collaborator

@myakove myakove commented Sep 3, 2023

  • Wait for resource exists before sampling for condition

  • return None in self.instance

  • TimeoutSampler: rempve dulicate exception log

Short description:
More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
Bug:

* Wait for resource exists before sampling for condition

* return None in self.instance

* TimeoutSampler: rempve dulicate exception log

Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com>
@redhat-qe-bot
Copy link
Contributor

Report bugs in Issues

The following are automatically added:

  • Add reviewers from OWNER file (in the root of the repository) under reviewers section.
  • Set PR size label.
  • New issue is created for the PR. (Closed when PR is merged/closed)
  • Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

  • To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
  • To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
    • Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
    • Cherry-pick will be started when PR is merged
  • To re-run tox comment /retest tox in the PR.
  • To re-run build-container command /retest build-container in the PR.
  • To re-run python-module-install command /retest python-module-install in the PR.
  • To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
  • To add a label by comment use /<label name>, to remove, use /<label name> cancel
Supported labels
  • hold
  • verified
  • wip
  • lgtm

@myakove
Copy link
Collaborator Author

myakove commented Sep 3, 2023

/verified

@myakove myakove enabled auto-merge (squash) September 3, 2023 11:02
@myakove myakove merged commit d889dca into v4.13 Sep 3, 2023
@myakove myakove deleted the CherryPicked-wait_for_condition-wait-for-exists-ZQieE-v4.13 branch September 3, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants