Update catalog_source class constructor, documentation and add 'to_dict' parameters validation #1412

oharan2 · 2023-09-06T09:00:49Z

Short description:

Fix class constructor to not demand upper (super) classes args, fixed documentation

redhat-qe-bot · 2023-09-06T09:00:53Z

Report bugs in Issues

The following are automatically added:

Add reviewers from OWNER file (in the root of the repository) under reviewers section.
Set PR size label.
New issue is created for the PR. (Closed when PR is merged/closed)
Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
verified label removed on each new commit push.
To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
- Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
- Cherry-pick will be started when PR is merged
To re-run tox comment /retest tox in the PR.
To re-run build-container command /retest build-container in the PR.
To re-run python-module-install command /retest python-module-install in the PR.
To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
To add a label by comment use /<label name>, to remove, use /<label name> cancel

Supported labels

hold
verified
wip
lgtm

ocp_resources/catalog_source.py

for more information, see https://pre-commit.ci

…wrapper into catalog_source

for more information, see https://pre-commit.ci

oharan2 · 2023-09-11T11:56:44Z

/verified

myakove · 2023-09-12T09:44:02Z

/lgtm

myakove · 2023-09-12T09:44:52Z

/cherry-pick v4.15 v4.14

redhat-qe-bot · 2023-09-12T09:44:57Z

Cherry-pick requested for PR: Update catalog_source class constructor, documentation and add 'to_dict' parameters validation by user myakove
Adding label/s cherry-pick-v4.14 cherry-pick-v4.15 for automatic cheery-pick once the PR is merged

myakove · 2023-09-12T09:46:02Z

/verified

…ct' parameters validation (#1412) * Update catalog_source class constructor and documentation * Add to_dict parameter validtion * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix logic * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com>

redhat-qe-bot · 2023-09-12T09:46:34Z

Cherry-picked PR Update catalog_source class constructor, documentation and add 'to_dict' parameters validation into v4.14

…ct' parameters validation (#1412) * Update catalog_source class constructor and documentation * Add to_dict parameter validtion * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix logic * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com>

redhat-qe-bot · 2023-09-12T09:46:46Z

Cherry-picked PR Update catalog_source class constructor, documentation and add 'to_dict' parameters validation into v4.15

…ct' parameters validation (#1412) (#1458) * Update catalog_source class constructor and documentation * Add to_dict parameter validtion * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix logic * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: oharan2 <oharan@redhat.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com>

…ct' parameters validation (#1412) (#1459) * Update catalog_source class constructor and documentation * Add to_dict parameter validtion * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix logic * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: oharan2 <oharan@redhat.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com>

…ct' parameters validation (#1412) * Update catalog_source class constructor and documentation * Add to_dict parameter validtion * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix logic * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com>

Update catalog_source class constructor and documentation

bf5c52c

redhat-qe-bot mentioned this pull request Sep 6, 2023

Update catalog_source class constructor and documentation - 1412 #1413

Closed

redhat-qe-bot added size/S branch-main labels Sep 6, 2023

redhat-qe-bot requested review from myakove, omrirh and rnetser September 6, 2023 09:01

oharan2 mentioned this pull request Sep 6, 2023

Add validation for mandatory args for class constructor in 'catalog_source.py' #1414

Closed

rnetser requested changes Sep 6, 2023

View reviewed changes

ocp_resources/catalog_source.py Show resolved Hide resolved

redhat-qe-bot added ChangesRequestedBy-rnetser CommentedBy-oharan2 CommentedBy-rnetser labels Sep 6, 2023

Add to_dict parameter validtion

7866a96

redhat-qe-bot removed ChangesRequestedBy-rnetser CommentedBy-oharan2 CommentedBy-rnetser labels Sep 11, 2023

redhat-qe-bot requested a review from rnetser September 11, 2023 11:51

pre-commit-ci bot and others added 2 commits September 11, 2023 11:51

[pre-commit.ci] auto fixes from pre-commit.com hooks

b596b34

for more information, see https://pre-commit.ci

Fix logic

5f40cff

redhat-qe-bot added the needs-rebase label Sep 11, 2023

oharan2 and others added 3 commits September 11, 2023 14:54

Merge branch 'catalog_source' of github.com:oharan2/openshift-python-…

8fd3bf4

…wrapper into catalog_source

[pre-commit.ci] auto fixes from pre-commit.com hooks

dbbed5e

for more information, see https://pre-commit.ci

Merge branch 'main' into catalog_source

66953d7

redhat-qe-bot added verified and removed needs-rebase labels Sep 11, 2023

oharan2 changed the title ~~Update catalog_source class constructor and documentation~~ Update catalog_source class constructor, documentation and add 'to_dict' parameters validation Sep 11, 2023

rnetser approved these changes Sep 11, 2023

View reviewed changes

redhat-qe-bot added the ApprovedBy-rnetser label Sep 11, 2023

redhat-qe-bot requested a review from rnetser September 11, 2023 15:35

redhat-qe-bot added the verified label Sep 11, 2023

rnetser approved these changes Sep 12, 2023

View reviewed changes

redhat-qe-bot added ApprovedBy-rnetser needs-rebase labels Sep 12, 2023

Merge branch 'main' into catalog_source

21e77f9

redhat-qe-bot added ApprovedBy-myakove and removed ApprovedBy-rnetser verified labels Sep 12, 2023

redhat-qe-bot requested a review from rnetser September 12, 2023 09:44

redhat-qe-bot added the cherry-pick-v4.14 label Sep 12, 2023

myakove enabled auto-merge (squash) September 12, 2023 09:45

redhat-qe-bot added the cherry-pick-v4.15 label Sep 12, 2023

redhat-qe-bot added verified can-be-merged labels Sep 12, 2023

myakove merged commit 32baac3 into RedHatQE:main Sep 12, 2023

redhat-qe-bot removed the needs-rebase label Sep 12, 2023

redhat-qe-bot mentioned this pull request Sep 12, 2023

CherryPicked: [v4.14] Update catalog_source class constructor, documentation and add to_dict parameters validation #1458

Merged

redhat-qe-bot mentioned this pull request Sep 12, 2023

CherryPicked: [v4.15] Update catalog_source class constructor, documentation and add to_dict parameters validation #1459

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update catalog_source class constructor, documentation and add 'to_dict' parameters validation #1412

Update catalog_source class constructor, documentation and add 'to_dict' parameters validation #1412

Uh oh!

oharan2 commented Sep 6, 2023

Uh oh!

redhat-qe-bot commented Sep 6, 2023

Uh oh!

Uh oh!

oharan2 commented Sep 11, 2023

Uh oh!

myakove commented Sep 12, 2023

Uh oh!

myakove commented Sep 12, 2023

Uh oh!

redhat-qe-bot commented Sep 12, 2023

Uh oh!

myakove commented Sep 12, 2023

Uh oh!

redhat-qe-bot commented Sep 12, 2023

Uh oh!

redhat-qe-bot commented Sep 12, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Update catalog_source class constructor, documentation and add 'to_dict' parameters validation #1412

Update catalog_source class constructor, documentation and add 'to_dict' parameters validation #1412

Uh oh!

Conversation

oharan2 commented Sep 6, 2023

Short description:

Uh oh!

redhat-qe-bot commented Sep 6, 2023

Uh oh!

Uh oh!

oharan2 commented Sep 11, 2023

Uh oh!

myakove commented Sep 12, 2023

Uh oh!

myakove commented Sep 12, 2023

Uh oh!

redhat-qe-bot commented Sep 12, 2023

Uh oh!

myakove commented Sep 12, 2023

Uh oh!

redhat-qe-bot commented Sep 12, 2023

Uh oh!

redhat-qe-bot commented Sep 12, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants