-
Notifications
You must be signed in to change notification settings - Fork 67
Update controller_revision class constructor, documentation and add 'to_dict' parameters validation #1444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Update controller_revision class constructor, documentation and add 'to_dict' parameters validation #1444
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
c2187c0
Update controller_revision class constructor, documentation and add '…
oharan2 83d0d7d
Merge branch 'main' of https://github.com/RedHatQE/openshift-python-w…
oharan2 1a88fca
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] feae89a
Merge branch 'main' of https://github.com/RedHatQE/openshift-python-w…
oharan2 8a6cb2c
Update revision argument and fix class documentation
oharan2 3daa1d7
Merge branch 'controller_revision' of github.com:oharan2/openshift-py…
oharan2 f282048
Pre commit
oharan2 b37bd61
Merge branch 'main' into controller_revision
oharan2 f688e50
Merge branch 'main' into controller_revision
oharan2 979ff67
Merge branch 'main' into controller_revision
oharan2 fe1712d
Add numpy to pyproject.toml
oharan2 da46f33
Merge branch 'main' into controller_revision
oharan2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -64,3 +64,4 @@ python-benedict = "^0.32.0" | |
| packaging = "^23.1" | ||
| python-simple-logger = "^1.0.6" | ||
| jinja2 = "^3.1.2" | ||
| numpy = "*" | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do not edit this file directly, use poetry add |
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You specify that the code expect
int64but in the code you convert it toint64We need to get it from the user and only validate that the user was sent us
int64