Skip to content

Adding topology option to the overlay NAD #1569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 8, 2024
Merged

Adding topology option to the overlay NAD #1569

merged 1 commit into from
Jan 8, 2024

Conversation

@Anatw
Copy link
Contributor

@Anatw Anatw commented Jan 1, 2024

Short description:

Adding topology option to the overlay NAD resource.

More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
Bug:

@redhat-qe-bot
Copy link
Contributor

redhat-qe-bot commented Jan 1, 2024

Report bugs in Issues

The following are automatically added:

  • Add reviewers from OWNER file (in the root of the repository) under reviewers section.
  • Set PR size label.
  • New issue is created for the PR. (Closed when PR is merged/closed)
  • Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

  • To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
  • To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
    • Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
    • Cherry-pick will be started when PR is merged
  • To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
  • To add a label by comment use /<label name>, to remove, use /<label name> cancel
Supported /retest check runs
  • /retest tox: Retest tox
  • /retest sonarqube: Retest sonarqube
  • /retest python-module-install: Retest python-module-install
Supported labels
  • hold
  • verified
  • wip
  • lgtm

@Anatw
Copy link
Contributor Author

Anatw commented Jan 1, 2024

/verified

myakove
myakove requested changes Jan 2, 2024
View reviewed changes
@Anatw Anatw force-pushed the refactor_nad_overlay_infrastructure branch from f2c948d to 7964c28 Compare January 2, 2024 09:51
@redhat-qe-bot redhat-qe-bot requested a review from myakove January 2, 2024 09:51
rnetser
rnetser requested changes Jan 2, 2024
View reviewed changes
Copy link
Collaborator

@rnetser rnetser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update api doc link

@Anatw Anatw force-pushed the refactor_nad_overlay_infrastructure branch from 7964c28 to 0482286 Compare January 4, 2024 09:22
@redhat-qe-bot redhat-qe-bot requested a review from rnetser January 4, 2024 09:22
myakove
myakove previously approved these changes Jan 4, 2024
View reviewed changes
rnetser
rnetser requested changes Jan 4, 2024
View reviewed changes
@Anatw Anatw force-pushed the refactor_nad_overlay_infrastructure branch from 0482286 to d0bc714 Compare January 4, 2024 12:55
myakove
myakove requested changes Jan 4, 2024
View reviewed changes
@Anatw
Adding topology option to the overlay NAD
5031750 
Signed-off-by: Anat Wax <awax@redhat.com>
@Anatw Anatw force-pushed the refactor_nad_overlay_infrastructure branch from d0bc714 to 5031750 Compare January 7, 2024 10:14
@redhat-qe-bot redhat-qe-bot requested a review from myakove January 7, 2024 10:15
@Anatw
Copy link
Contributor Author

Anatw commented Jan 8, 2024

/verified

@myakove myakove merged commit f4ff23c into RedHatQE:main Jan 8, 2024
@Anatw
Copy link
Contributor Author

Anatw commented Jan 8, 2024

!cherry-pick v4.15

@Anatw
Copy link
Contributor Author

Anatw commented Jan 8, 2024

/cherry-pick v4.15

redhat-qe-bot pushed a commit that referenced this pull request Jan 8, 2024
@Anatw
Adding topology option to the overlay NAD (#1569)
d27291d 
Signed-off-by: Anat Wax <awax@redhat.com>
@redhat-qe-bot redhat-qe-bot mentioned this pull request Jan 8, 2024
Merged
@redhat-qe-bot
Copy link
Contributor

redhat-qe-bot commented Jan 8, 2024

Cherry-picked PR Adding topology option to the overlay NAD into v4.15

redhat-qe-bot added a commit that referenced this pull request Jan 8, 2024
@redhat-qe-bot @Anatw
Adding topology option to the overlay NAD (#1569) (#1571)
5dee69f 
Signed-off-by: Anat Wax <awax@redhat.com>
Co-authored-by: ‪Anat Wax <46938838+Anatw@users.noreply.github.com>
myakove pushed a commit that referenced this pull request Aug 11, 2025
@Anatw
Adding topology option to the overlay NAD (#1569)
83338e3 
Signed-off-by: Anat Wax <awax@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@myakove myakove myakove approved these changes

@rnetser rnetser rnetser approved these changes

@omrirh omrirh Awaiting requested review from omrirh

@oharan2 oharan2 Awaiting requested review from oharan2

Assignees

No one assigned

Labels

approved-myakove approved-rnetser branch-main can-be-merged size/XS verified

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Anatw @redhat-qe-bot @myakove @rnetser