Skip to content

Conversation

@hmeir
Copy link
Contributor

@hmeir hmeir commented Jan 23, 2024

Short description:

Accessing StorageProfile status properties is very common, for example accessmode, volumemode, cloneStrategy etc.
Adding properties will allow easier access.
Also two function to get the first claimPropertySets accessmode & volume mode, very common in our tests as well.
In addition, Adding storage_profile property to StorageClass, because its very common to get the matching StorageProfile of the Storageclass.

What this PR does / why we need it:

Adding four common StorageProfile parameters as properties for easier Access.
In addition two functions for accessmode and volumemode.
Adding storage_profile property for StorageClass.

@redhat-qe-bot
Copy link
Contributor

Report bugs in Issues

The following are automatically added:

  • Add reviewers from OWNER file (in the root of the repository) under reviewers section.
  • Set PR size label.
  • New issue is created for the PR. (Closed when PR is merged/closed)
  • Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

  • To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
  • To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
    • Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
    • Cherry-pick will be started when PR is merged
  • To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
  • To add a label by comment use /<label name>, to remove, use /<label name> cancel
Supported /retest check runs
  • /retest tox: Retest tox
  • /retest python-module-install: Retest python-module-install
Supported labels
  • hold
  • verified
  • wip
  • lgtm

@hmeir
Copy link
Contributor Author

hmeir commented Jan 29, 2024

/verified

hmeir added 2 commits February 8, 2024 10:26
Signed-off-by: Harel Meir <hmeir@redhat.com>
Signed-off-by: Harel Meir <hmeir@redhat.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 8, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@hmeir
Copy link
Contributor Author

hmeir commented Feb 8, 2024

/verified

@hmeir
Copy link
Contributor Author

hmeir commented Feb 8, 2024

/cherry-pick v4.15

redhat-qe-bot pushed a commit that referenced this pull request Feb 8, 2024
* Add storageprofile property to wrapper

Signed-off-by: Harel Meir <hmeir@redhat.com>

* Add storageProfile properties to easier access

Signed-off-by: Harel Meir <hmeir@redhat.com>

---------

Signed-off-by: Harel Meir <hmeir@redhat.com>
@redhat-qe-bot
Copy link
Contributor

Cherry-picked PR Add StorageProfile properties into v4.15

redhat-qe-bot added a commit that referenced this pull request Feb 8, 2024
* Add storageprofile property to wrapper



* Add storageProfile properties to easier access



---------

Signed-off-by: Harel Meir <hmeir@redhat.com>
Co-authored-by: Harel Meir <hmeir@redhat.com>
redhat-qe-bot added a commit that referenced this pull request Feb 15, 2024
* Add storageprofile property to wrapper



* Add storageProfile properties to easier access



---------

Signed-off-by: Harel Meir <hmeir@redhat.com>
Co-authored-by: Harel Meir <hmeir@redhat.com>
redhat-qe-bot1 pushed a commit that referenced this pull request Feb 15, 2024
* Add storageprofile property to wrapper



* Add storageProfile properties to easier access



---------

Signed-off-by: Harel Meir <hmeir@redhat.com>
Co-authored-by: Harel Meir <hmeir@redhat.com>
myakove pushed a commit that referenced this pull request Aug 11, 2025
* Add storageprofile property to wrapper

Signed-off-by: Harel Meir <hmeir@redhat.com>

* Add storageProfile properties to easier access

Signed-off-by: Harel Meir <hmeir@redhat.com>

---------

Signed-off-by: Harel Meir <hmeir@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants