Skip to content

Add vlan and mtu parameters to OVNOverlayNetworkAttachmentDefinition #1697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 2, 2024
Merged

Add vlan and mtu parameters to OVNOverlayNetworkAttachmentDefinition #1697

merged 4 commits into from
Apr 2, 2024

Conversation

@Anatw
Copy link
Contributor

@Anatw Anatw commented Mar 4, 2024

Short description:

Add vlan and mtu parameters to OVNOverlayNetworkAttachmentDefinition.

What this PR does / why we need it:

Needed for the localnet feature.

@redhat-qe-bot
Copy link
Contributor

redhat-qe-bot commented Mar 4, 2024

Report bugs in Issues

The following are automatically added:

  • Add reviewers from OWNER file (in the root of the repository) under reviewers section.
  • Set PR size label.
  • New issue is created for the PR. (Closed when PR is merged/closed)
  • Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

  • To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
  • To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
    • Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
    • Cherry-pick will be started when PR is merged
  • To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
  • To add a label by comment use /<label name>, to remove, use /<label name> cancel
  • To assign reviewers based on OWNERS file use /assign-reviewers
  • To check if PR can be merged use /check-can-merge
Supported /retest check runs
  • /retest tox: Retest tox
  • /retest python-module-install: Retest python-module-install
Supported labels
  • hold
  • verified
  • wip
  • lgtm

myakove
myakove requested changes Mar 5, 2024
View reviewed changes
@Anatw Anatw force-pushed the add_vlan_mtu_to_layer2_nad branch from 16ec497 to f0b08c9 Compare March 7, 2024 09:21
@redhat-qe-bot1 redhat-qe-bot1 requested a review from myakove March 7, 2024 09:22
@myakove
Copy link
Collaborator

myakove commented Mar 7, 2024

/hold

@Anatw Anatw force-pushed the add_vlan_mtu_to_layer2_nad branch from 4af8117 to 6408d23 Compare March 18, 2024 12:23
myakove
myakove requested changes Mar 21, 2024
View reviewed changes
@Anatw
Copy link
Contributor Author

Anatw commented Mar 27, 2024

/verified

@Anatw
Copy link
Contributor Author

Anatw commented Mar 28, 2024

/verified

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 31, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Anatw
Copy link
Contributor Author

Anatw commented Apr 1, 2024

/verified

@myakove myakove merged commit e58f3eb into RedHatQE:main Apr 2, 2024
@Anatw
Copy link
Contributor Author

Anatw commented Apr 2, 2024

/cherry-pick v4.15

redhat-qe-bot pushed a commit that referenced this pull request Apr 2, 2024
@Anatw
Add vlan and mtu parameters to OVNOverlayNetworkAttachmentDefinition (#…
46687a8 
…1697)

Signed-off-by: Anat Wax <awax@redhat.com>
@redhat-qe-bot redhat-qe-bot mentioned this pull request Apr 2, 2024
Merged
@redhat-qe-bot
Copy link
Contributor

redhat-qe-bot commented Apr 2, 2024

Cherry-picked PR Add vlan and mtu parameters to OVNOverlayNetworkAttachmentDefinition into v4.15

redhat-qe-bot1 pushed a commit that referenced this pull request Apr 2, 2024
@redhat-qe-bot @Anatw
Add vlan and mtu parameters to OVNOverlayNetworkAttachmentDefinition (#…
5c28e43 
…1697) (#1760)

Signed-off-by: Anat Wax <awax@redhat.com>
Co-authored-by: ‪Anat Wax <46938838+Anatw@users.noreply.github.com>
@NedAnonymous7509
Copy link

NedAnonymous7509 commented Apr 3, 2024

What does it do???

@myakove myakove mentioned this pull request Apr 21, 2024
Merged
@segevyos segevyos mentioned this pull request Apr 21, 2024
Closed
myakove pushed a commit that referenced this pull request Aug 11, 2025
@Anatw
Add vlan and mtu parameters to OVNOverlayNetworkAttachmentDefinition (#…
3e8ebbe 
…1697)

Signed-off-by: Anat Wax <awax@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@myakove myakove myakove approved these changes

@rnetser rnetser rnetser approved these changes

@omrirh omrirh Awaiting requested review from omrirh

Assignees

No one assigned

Labels

approved-myakove approved-rnetser branch-main can-be-merged size/S verified

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Anatw @redhat-qe-bot @myakove @NedAnonymous7509 @rnetser @redhat-qe-bot1 @redhat-qe-bot2 @rh-bot-1