Skip to content

Fix camel case #1979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 30, 2024
Merged

Fix camel case #1979

merged 3 commits into from
Jul 30, 2024

Conversation

@rnetser
Copy link
Collaborator

@rnetser rnetser commented Jul 30, 2024

Address cases where:

  • last 2 words in string are: 1 uppercase followed by 1 title - e.g: dataVolumeTTLSeconds
  • last wordsin string is with acronym and ends with lowercase - e.g: clusterIPs

@rh-bot-1
Copy link

rh-bot-1 commented Jul 30, 2024

Report bugs in Issues

The following are automatically added:

  • Add reviewers from OWNER file (in the root of the repository) under reviewers section.
  • Set PR size label.
  • New issue is created for the PR. (Closed when PR is merged/closed)
  • Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

  • To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
  • To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
    • Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
    • Cherry-pick will be started when PR is merged
  • To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
    • You can add extra args to the Podman build command
      • Example: /build-and-push-container --build-arg OPENSHIFT_PYTHON_WRAPPER_COMMIT=<commit_hash>
  • To add a label by comment use /<label name>, to remove, use /<label name> cancel
  • To assign reviewers based on OWNERS file use /assign-reviewers
  • To check if PR can be merged use /check-can-merge
Supported /retest check runs
  • /retest tox: Retest tox
  • /retest python-module-install: Retest python-module-install
Supported labels
  • hold
  • verified
  • wip
  • lgtm

@rh-bot-1 rh-bot-1 mentioned this pull request Jul 30, 2024
Closed
@rh-bot-1 rh-bot-1 requested a review from myakove July 30, 2024 10:33
@rh-bot-1 rh-bot-1 requested a review from omrirh July 30, 2024 10:33
@rnetser
Copy link
Collaborator Author

rnetser commented Jul 30, 2024

/verified

myakove
myakove requested changes Jul 30, 2024
View reviewed changes
@rnetser
Copy link
Collaborator Author

rnetser commented Jul 30, 2024

/verified

@rh-bot-1 rh-bot-1 requested a review from myakove July 30, 2024 10:44
myakove
myakove previously approved these changes Jul 30, 2024
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@redhat-qe-bot2 redhat-qe-bot2 requested a review from myakove July 30, 2024 10:56
@rnetser
Copy link
Collaborator Author

rnetser commented Jul 30, 2024

/verified

@myakove myakove enabled auto-merge (squash) July 30, 2024 10:57
@rnetser
Copy link
Collaborator Author

rnetser commented Jul 30, 2024

/verified cancel

@rnetser
Copy link
Collaborator Author

rnetser commented Jul 30, 2024

/verified

@myakove myakove merged commit c8b9dd7 into main Jul 30, 2024
@myakove myakove deleted the fix-case2 branch July 30, 2024 11:03
myakove pushed a commit that referenced this pull request Aug 11, 2025
@rnetser
Fix camel case (#1979)
e8a217f 
* Fix camel case

* add exmaple

* fix code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@myakove myakove myakove approved these changes

@omrirh omrirh Awaiting requested review from omrirh

Assignees

No one assigned

Labels

approved-myakove branch-main can-be-merged JIRA:MSINTEROP-1323 size/S verified

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@rnetser @rh-bot-1 @myakove @redhat-qe-bot @redhat-qe-bot1 @redhat-qe-bot2