Skip to content

CherryPicked: [v4.16] fix IndexError if no virt-launcher pod #2227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2024
Merged

CherryPicked: [v4.16] fix IndexError if no virt-launcher pod #2227

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ocp_resources/virtual_machine_instance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,9 @@ def virt_launcher_pod(self):
label_selector=f"kubevirt.io=virt-launcher,kubevirt.io/created-by={self.instance.metadata.uid}",
)
)
if not pods:
raise ResourceNotFoundError(f"VIRT launcher POD not found for {self.kind}:{self.name}")

migration_state = self.instance.status.migrationState
if migration_state:
# After VM migration there are two pods, one in Completed status and one in Running status.
Expand All @@ -85,8 +88,6 @@ def virt_launcher_pod(self):
else:
return pods[0]

raise ResourceNotFoundError(f"VIRT launcher POD not found for {self.kind}:{self.name}")

@property
def virt_handler_pod(self):
pods = list(
Expand Down