add mypy and update files #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Report bugs in Issues The following are automatically added:
Available user actions:
Supported /retest check runs
Supported labels
|
rnetser
requested changes
Apr 25, 2024
| data = subprocess.check_output(shlex.split("git diff HEAD^-1")) | ||
| data = data.decode("utf-8") | ||
| return data | ||
| return data.decode("utf-8") |
Collaborator
There was a problem hiding this comment.
utf-8 is the default; can be removed
|
|
||
| def git_diff_lines(): | ||
| diff = {} | ||
| def git_diff_lines() -> dict: |
Collaborator
There was a problem hiding this comment.
Suggested change
| def git_diff_lines() -> dict: | |
| def git_diff_lines() -> Dict: |
| polarion_test_ids, | ||
| polarion_project_id, | ||
| ): | ||
| polarion_test_ids: list, |
Collaborator
There was a problem hiding this comment.
Suggested change
| polarion_test_ids: list, | |
| polarion_test_ids: List, |
| ) -> list: | ||
| from pylero.work_item import TestCase, Requirement | ||
|
|
||
| tests_with_missing_requirements = [] |
Collaborator
There was a problem hiding this comment.
Suggested change
| tests_with_missing_requirements = [] | |
| tests_with_missing_requirements : List = [] |
Collaborator
There was a problem hiding this comment.
typing is missing in some definitions
| @click.option("--project-id", "-p", help="Provide the polarion project id") | ||
| @click.option("--verbosity", default=False, is_flag=True) | ||
| def has_verify(config_file_path, project_id, verbosity): | ||
| def has_verify(config_file_path: Any, project_id: str, verbosity: bool) -> Any: |
Collaborator
There was a problem hiding this comment.
why config_file_path is Any?
Collaborator
There was a problem hiding this comment.
why -> Any, the function does not return anything
| """ | ||
|
|
||
| def is_func(_elm): | ||
| def is_func(_elm: Any) -> Any: |
Collaborator
There was a problem hiding this comment.
why Any? please fix in all places. this function returns bool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.