Use real URL, taking care of default pages #2

Merged
merged 3 commits into from Jul 4, 2013

Projects

None yet

2 participants

@jnachtigall
Contributor

Actually just one fix in opengraph_meta.pt

    <meta property="og:url" content="URL of this object"
          tal:attributes="content context/@@plone_context_state/canonical_object_url" />

Using the /canonical_object_url instead of Zope's absolute_url in order to handle "default pages" of folders (e.g. I want to share /events not /events/aggregator)

jnachtigall added some commits Jun 22, 2013
@jnachtigall jnachtigall Use real URL, take care of default pages
If I want do share something like "/events", I do not want to have the URL to have as "events/aggregator". This is important for all folder that have a "default page".

see https://svn.plone.org/svn/plone/plone.app.layout/trunk/plone/app/layout/globals/interfaces.py for the various methods to get the URL of an object
0f015c2
@jnachtigall jnachtigall Use real URL, take care of default pages
If there is a page being set as default page of /news then its image would be /news/mydefaultpage/myleadimage...
b84a16f
@jnachtigall jnachtigall revert changes 91a123d
@keul
Contributor
keul commented Jun 24, 2013

Seems really good to me. Have you time to add also a specific test for this new change?
I can add it by my self when I found some time.

@jnachtigall
Contributor

I'd really love to but I haven't got the time. Sorry :-(

@keul
Contributor
keul commented Jun 27, 2013

No problem, I can add it for you when I'll find some times. Thanks!

@keul keul merged commit d854bb3 into RedTurtle:master Jul 4, 2013
@keul keul added a commit that referenced this pull request Jul 5, 2013
@keul keul added a test for checking issue #2 be4c460
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment