Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes necessary to build in F24 with GCC6 (std-c++14). #32

Closed
wants to merge 1 commit into from

Conversation

@bhilburn
Copy link

@bhilburn bhilburn commented Jul 27, 2016

Changeset is originally referenced / described in my StackOverflow question.

Two of the changes appear to be GCC6 related, but the other two changes look like they would be necessary no matter the C++ standard in use. Since the relevant lines were last modified in February, it seems that if they were indeed bugs that they would have been fixed by now. Thus, I think these need careful review.

The constexpr keyword was added to C++ in c++11. I wasn't able to find docs that called out what versions of the standard RedhawkSDR needed to support - if something earlier is needed, this will probably need to be addressed by the preprocessor.

That said, with this changeset, I was able to build the CF in F24, as was @bagoulla. The changeset is also referenced in this openembedded-hawk bug report.

@maxrobert
Copy link
Member

@maxrobert maxrobert commented Mar 7, 2019

This issue was resolved in a different way than suggested in the pull request and released in the RH 2.1.3 version and the RH 2.2.x baseline

@maxrobert maxrobert closed this Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants