Issue993 FT.DEL redismodule_replicate #1000
Conversation
ashtul
commented
Dec 2, 2019
ashtul
commented
- Removed string not is place
- Added correct parsing for DD
- Tests
|
@ashtul you proably wanted to make this PR against the 1.4 branch |
src/pytest/test_replicate.py
Outdated
| time.sleep(5) | ||
| # Ensure slave is updated | ||
| master.execute_command('set foo bar') | ||
| try: |
There was a problem hiding this comment.
I don't see why we need try here; it should just fail..
There was a problem hiding this comment.
I got the code from @MeirShpilraien.
I believe this will give a cleaner error message on the test.
There was a problem hiding this comment.
Mark I believe that a general timeout code is better then checking the time each iteration. Code looks cleaner.
| found = True | ||
| break | ||
| time.sleep(0.01) | ||
|
|
There was a problem hiding this comment.
@mnunberg remove found all together
| found = False | ||
| break | ||
| time.sleep(0.01) | ||
|
|
There was a problem hiding this comment.
remove found all together
src/pytest/test_replicate.py
Outdated
| master.execute_command('ft.add', 'idx', 'doc%d' % i, 1.0, 'fields', | ||
| 'f', 'hello world') | ||
| # Ensure slave is updated | ||
| master.execute_command('set foo bar') |
There was a problem hiding this comment.
This is not the correct way to check it, when we move the replicate to the indexer thread the set might get to the slave before the ft.add command. The correct way is try to get the document from the slave with timeout as I suggested from the first place ...
src/pytest/test_replicate.py
Outdated
| master.execute_command('ft.add', 'idx', 'doc%d' % i, 1.0, 'fields', | ||
| 'f', 'hello world') | ||
|
|
||
| checkSlaveSynced(env, slave, ('ft.get', 'idx', 'doc0'), ['f', 'hello world']) |
There was a problem hiding this comment.
I would check the last document and not the first
|
@mnunberg @MeirShpilraien @gkorland |
