Please make the build reproducible #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whilst working on the Reproducible Builds effort [0], we noticed that redisearch could not be built reproducibly. This is because it links (etc.) in filesystem ordering which is non-determinstic. Adding some $(sort ...) calls fixes this for me. You can test this by using our "disorderfs" tool to mangle the directory ordering. [0] https://reproducible-builds.org/
|
Just out of curiosity - what situation makes the build (without your fix) fail? |
|
Fail? The build is not failing, it does just not produce the same binary every time. :) |
|
Oh I see. Ok cool. I wasn't aware of it. Will merge once I'm near a
computer.
…On Sun, Feb 18, 2018, 2:19 PM Chris Lamb ***@***.***> wrote:
Fail? The build is not failing, it does just not produce the same binary
every time. :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#289 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAetutb3kgBYI-1D9FGwY62A6IPt2iSSks5tWBVlgaJpZM4SJf0w>
.
|
|
Thanks! |
|
Any chance of a release with this in? :) |
|
@lamby sure, we've squashed a potential crash as well, so I guess a new bug fix release is due. I'll try to release it tomorrow. |
|
Gentle ping on this @dvirsky :) |
|
Ooops, forgot about it :) I'll do it today hopefully. |
|
@lamby 1.0.8 is out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Whilst working on the Reproducible Builds effort [0], we noticed
that redisearch could not be built reproducibly. This is because
it links (etc.) in filesystem ordering which is non-determinstic.
Adding some $(sort ...) calls fixes this for me. You can test this
by using our "disorderfs" tool to mangle the directory ordering.
[0] https://reproducible-builds.org/