Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transposed delta matrix should be cols X rows #1942

Merged
merged 2 commits into from Sep 17, 2021
Merged

Conversation

swilly22
Copy link
Collaborator

Luckily enough all of our matrices are squared...

@swilly22 swilly22 added the bug label Sep 16, 2021
@swilly22 swilly22 self-assigned this Sep 16, 2021
Copy link
Contributor

@jeffreylovitz jeffreylovitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good catch!

@codecov
Copy link

codecov bot commented Sep 16, 2021

Codecov Report

Merging #1942 (cc9b2e3) into master (d35d498) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head cc9b2e3 differs from pull request most recent head c155658. Consider uploading reports for the commit c155658 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1942      +/-   ##
==========================================
- Coverage   92.63%   92.62%   -0.01%     
==========================================
  Files         239      239              
  Lines       20324    20324              
==========================================
- Hits        18827    18826       -1     
- Misses       1497     1498       +1     
Impacted Files Coverage Δ
src/graph/rg_matrix/rg_new.c 100.00% <100.00%> (ø)
src/graph/rg_matrix/rg_resize.c 100.00% <100.00%> (ø)
src/util/thpool/thpool.c 82.38% <0.00%> (-0.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d35d498...c155658. Read the comment docs.

@swilly22 swilly22 merged commit 90351f2 into master Sep 17, 2021
@swilly22 swilly22 deleted the delta-matrices-resize branch September 17, 2021 12:08
pnxguide pushed a commit to CMU-SPEED/RedisGraph that referenced this pull request Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants