Skip to content

fix for bug with field-types indices not being correctly referenced #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 8, 2019
Merged

fix for bug with field-types indices not being correctly referenced #11

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1b1d6e1
allows any csv quote format
Aug 21, 2019
e89eae8
updates bulk loader to be able to set types explicitly
Aug 21, 2019
b753eb4
updates documentation and help
Aug 21, 2019
99be75a
set default field types to none
Aug 21, 2019
aab4300
adds exception when field types is malformed
Aug 21, 2019
1c4d421
puts type in repr
Aug 21, 2019
bca8103
updates readme
Aug 21, 2019
ced36c1
fixes bug with field-types indices not being correctly referenced
Oct 31, 2019
782e6e5
merged
Oct 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bulk_insert.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,13 +159,13 @@ def pack_header(self, header):
def pack_props(self, line):
props = []
for num, field in enumerate(line[self.prop_offset:]):
field_type_idx = self.prop_offset+num
try :
FIELD_TYPES[self.entity_str][num]
Copy link
Contributor

@jeffreylovitz jeffreylovitz Oct 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, let's change this line to index into field_type_idx rather than num.

except :
props.append(prop_to_binary(field, None))
else :
props.append(prop_to_binary(field, FIELD_TYPES[self.entity_str][num]))

props.append(prop_to_binary(field, FIELD_TYPES[self.entity_str][field_type_idx]))
return b''.join(p for p in props)

def to_binary(self):
Expand Down