adds ability to set field types explicitly #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bulk_insert.py
Outdated
| return struct.pack(format_str, Type.STRING, encoded_str) | ||
|
|
||
| ## if it hasn't returned by this point, it is trying to set it to a type that it can't adopt | ||
| raise Exception("unable to parse [" + prop_str + "] with type ["+type+"]") |
Contributor
There was a problem hiding this comment.
It would be better to print type as repr(type) or similar, as non-string values will raise a TypeError here.
jeffreylovitz
suggested changes
Aug 21, 2019
Contributor
jeffreylovitz
left a comment
jeffreylovitz
left a comment
There was a problem hiding this comment.
This is a great addition! I have two minor requests.
bulk_insert.py
Outdated
| QUOTING=csv.QUOTE_NONE | ||
| try : | ||
| FIELD_TYPES = json.loads(field_types) | ||
| except: FIELD_TYPES = None |
Contributor
There was a problem hiding this comment.
I think that failure to parse field_types should cause a printed warning or an exception (no strong preference between the two).
jeffreylovitz
approved these changes
Aug 21, 2019
Contributor
jeffreylovitz
left a comment
jeffreylovitz
left a comment
There was a problem hiding this comment.
Thanks very much, @renewooller ! This is a fantastic addition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.