Allow 0 (zero) and "" (empty string) to be returned as string. #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DvirDukhan
requested changes
Jan 26, 2020
Contributor
DvirDukhan
left a comment
DvirDukhan
left a comment
There was a problem hiding this comment.
@jsjacob
Thanks for this PR
LGTM
can you please add a simple unit test for this case?
Contributor
Author
I added several unit tests for Record. |
DvirDukhan
approved these changes
Feb 3, 2020
Contributor
DvirDukhan
left a comment
DvirDukhan
left a comment
There was a problem hiding this comment.
@jsjacob
Thanks!
I will merge it very soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
Record.getString()returnsnullfor 0 and "" (empty string). I don't think this is the intended behavior.This change makes the value test more explicit so 0 and "" are not returned as null.