fix: catch 404 errors in AA regions requests #95
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The subscriptions requests return a custom error type when the API returns a 404. The regions requests can also receive 404s when the subscription doesn't exist, so should also return the custom error type. Given that this corresponds to subscription not found errors, I have reused the same custom type in the subscriptions package.
This change results in a minor change to the existing error type, but it is not a breaking change as it changes a property from private to public, so nothing could be depending on it already