Skip to content

Conversation

@bengesoff
Copy link
Contributor

The subscriptions requests return a custom error type when the API returns a 404. The regions requests can also receive 404s when the subscription doesn't exist, so should also return the custom error type. Given that this corresponds to subscription not found errors, I have reused the same custom type in the subscriptions package.

This change results in a minor change to the existing error type, but it is not a breaking change as it changes a property from private to public, so nothing could be depending on it already

@bengesoff bengesoff merged commit 8c3bea8 into develop Feb 2, 2023
@bengesoff bengesoff deleted the fix/regions-not-found-error branch February 2, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants