Several network/protocol related fixes. #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New metrics include: * proxy_reqs: Total number of requests that were proxied. * proxy_failed_reqs: Requests that could not be proxied due to cluster/connection state; client receives an error reply. * proxy_failed_responses: Requests for which a valid response was not received; client receives a -TIMEOUT or other error in this case. * proxy_outstanding_reqs: Number of proxied requests waiting for reply from the leader.
When a leader receives a pre-bundled MULTI/EXEC transaction, it should process it immediately rather than attempt to re-bundle the individual commands.
This makes handling of hiredis contexts cleaner and more defensive, but it was not confirmed to fix any specific issue.
Error message was delivered on the wrong context, leaving the client blocked waiting for a reply or, if pipelining was used, getting out of sync with replies.
MULTI and DISCARD should never fail and always begin or terminate a transaction state. While in MULTI state, commands are simply +QUEUED and should never fail due to Raft cluster state either. Only EXEC itself applies Raft cluster state checks and may respond with errors such as -NOLEADER or -MOVED.
sjpotter
added a commit
to sjpotter/redisraft
that referenced
this pull request
Oct 7, 2021
create a self documenting function name instead of throwing in a bunch of conditions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes multiple issues that result with corrupted replies, stuck clients and/or consistency issues:
MULTI/EXECerror handling, see issue DISCARD doesn't always discard #25.MULTIcommands are delivered to the leader as a bundle, but erroneously go through theMULTI/EXECmechanism again which may interleave them with anything else on the same proxy connection.