Fix custom download URL filenames#2801
Open
cyphercodes wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why/How?
Custom
downloadUrlswithout an explicitdownloadFileNamecurrently inherit the generated-spec fallback filename (openapi.json). This forces YAML or other custom download URLs to save asopenapi.json.This change only applies the
openapi.jsonfallback when Redoc generates the downloadable spec itself. CustomdownloadUrlsnow leave the filename unset unlessdownloadFileNameis explicitly configured, so the browser can use the URL/content-disposition filename.Reference
Fixes #2787
Tests
npx jest src/services/__tests__/models/ApiInfo.test.ts --runInBand --coverage=falsenpm run ts-checknpx eslint src/services/models/ApiInfo.ts src/services/__tests__/models/ApiInfo.test.ts --no-cachenpx prettier --check src/services/models/ApiInfo.ts src/services/__tests__/models/ApiInfo.test.tsgit diff --checkScreenshots (optional)
N/A
Check yourself