Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Biome transition passageways are sometimes both controlled by Coalition #11577

Closed
1 of 2 tasks
HawkinsThe71st opened this issue Mar 17, 2023 · 8 comments
Closed
1 of 2 tasks
Assignees
Labels
Bug Something isn't working Code Programming task

Comments

@HawkinsThe71st
Copy link

Disclaimers

  • I have searched the issue tracker to check if the issue has already been reported.
  • My issue happened while using mods.

What happened?

Sometimes both of the passageways to the next biome are controlled by the Coalition, example save (created on unstable build):
sep test.zip

20230317175354_1
20230317175356_1

Reproduction steps

No response

Bug prevalence

Happens every now and then

Version

Unstable (v1.1.3.0)

-

No response

Which operating system did you encounter this bug on?

Windows

Relevant error messages and crash reports

No response

@itchyOwl itchyOwl added Bug Something isn't working Code Programming task labels Mar 28, 2023
@Regalis11
Copy link
Collaborator

Regalis11 commented Mar 30, 2023

Thank you for the report!

I tested starting a new campaign with the same map seed (VVGXc578), but unfortunately that didn't seem to result in the same map. I'm not quite sure how that's possible - the same seed should result in the same map (and without being able to generate the map, it's quite difficult to try to diagnose how it generated like this). To be sure, you weren't using any mods when creating this save? And it was created in the latest unstable version, v1.1.3.0?

@Regalis11 Regalis11 added the Need more info Insufficient information to resolve the issue (e.g. steps to reproduce a bug) label Mar 30, 2023
@HawkinsThe71st
Copy link
Author

I tested again and made sure I didn't have any mods enabled and managed to get the same map to generate using the map seed VVGXcS78
I think there is a minor typo in the seed you posted there (number 5 instead of the letter S)
602960_20230330133104_1
602960_20230330133200_1

@Regalis11
Copy link
Collaborator

I think there is a minor typo in the seed you posted there (number 5 instead of the letter S)

Ah, yes, that was the issue. 🤦‍♂️ Thank you!

@Regalis11 Regalis11 removed the Need more info Insufficient information to resolve the issue (e.g. steps to reproduce a bug) label Mar 31, 2023
@Regalis11
Copy link
Collaborator

Fixed in https://github.com/Regalis11/Barotrauma-development/commit/a85f06c97f1cfd7a3108afaff996c5cb977e486c

Fixed both biome gate locations sometimes belonging to the same faction (and in general, random locations getting changed into Coalition outposts across the map). Happened because we went through all locations to find the leftmost outpost on the map, and every time we found a more suitable one, we'd mark that as the start location and change it's faction to Coalition. Now we instead find the most suitable one first and only assign it then.

@Regalis11 Regalis11 changed the title [Unstable] Biome transition passageways are sometimes both controlled by Coalition Biome transition passageways are sometimes both controlled by Coalition Mar 31, 2023
@Jasontti
Copy link
Collaborator

Tested. Works on bunch of different seed, including VVGXcS78. Closing

@RooneyRoll
Copy link

Is the fix applied to the latest version "1.0.13.2" ?

@Regalis11
Copy link
Collaborator

Unfortunately not, we just got it tested internally 3 days ago so it isn't included in any public build yet. But hopefully in the next patch!

@RooneyRoll
Copy link

Unfortunately not, we just got it tested internally 3 days ago so it isn't included in any public build yet. But hopefully in the next patch!

Thank you for the information!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Code Programming task
Projects
None yet
Development

No branches or pull requests

5 participants