Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Able to run Update() independent circuits in submarine editor #5573

Closed
1 task done
Ecchi-Ki-Senpai opened this issue Apr 23, 2021 · 3 comments
Closed
1 task done

Able to run Update() independent circuits in submarine editor #5573

Ecchi-Ki-Senpai opened this issue Apr 23, 2021 · 3 comments
Assignees
Labels
Bug Something isn't working Code Programming task

Comments

@Ecchi-Ki-Senpai
Copy link

Ecchi-Ki-Senpai commented Apr 23, 2021

  • I have searched the issue tracker to check if the issue has already been reported.

Description
The RegEx component is able to send a signal outside of the game, like inside the sub editor, by inputting an invalid RegEx expression. The resulting output is an Error string which can be exploited by any component that output on an Update() independent basis.

Steps To Reproduce
See video

2021-04-22.21-25-30.mp4

Version
Windows, stable: 0.13.0.11

Additional information
Problem is this line of code: https://github.com/Regalis11/Barotrauma/blob/841d755394c6da98ec6de69e79c6ef65897fa07b/Barotrauma/BarotraumaShared/SharedSource/Items/Components/Signal/RegExFindComponent.cs#L64

This may cause issues in circuits that arn't expecting the value

@Regalis11 Regalis11 added Bug Something isn't working Code Programming task labels Apr 23, 2021
@Regalis11 Regalis11 self-assigned this Apr 23, 2021
@Regalis11
Copy link
Collaborator

@Ecchi-Ki-Senpai
Copy link
Author

Tested in 0.1300.1.11, unable to reproduce

@Rokvach
Copy link
Collaborator

Rokvach commented Apr 26, 2021

closing

@Rokvach Rokvach closed this as completed Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Code Programming task
Projects
None yet
Development

No branches or pull requests

3 participants