Floating point inaccuracy causes RequiredItem "Condition" check to fail

[notpeelz]

Disclaimers

• I have searched the issue tracker to check if the issue has already been reported.
• My issue happened while using mods.

What happened?

Given an item with this recipe:

<Fabricate suitablefabricators="fabricator" requiredtime="10">
  <RequiredSkill identifier="medical" level="30"/>
  <RequiredItem identifier="plastic"/>
  <RequiredItem identifier="rubber"/>
  <RequiredItem identifier="oxygentank"/>
</Fabricate>

It's currently impossible to craft it with an oxygen tank that was refilled in the oxygen generator, due to floating point inaccuracy.

This can be fixed by comparing the two values with a margin of error (epsilon).

Relevant lines: https://github.com/Regalis11/Barotrauma/blob/b17019db95865cc0551aa3a5a967e885a7f8b50d/Barotrauma/BarotraumaShared/SharedSource/Items/Components/Machines/Fabricator.cs#L605-L617

Reproduction steps

No response

Bug prevalence

Happens every time I play

Version

0.18.15.0

-

No response

Which operating system did you encounter this bug on?

Windows

Relevant error messages and crash reports

No response

[Regalis11]

Fixed in https://github.com/Regalis11/Barotrauma-development/commit/bb198cc0ba070357eebd842988f0c68779b58629

[NilanthAnimosus]

Tested against dev commit https://github.com/Regalis11/Barotrauma-development/commit/17a4e29619e49adc0a329be654296cf8f8ddc5d6, works correctly. closing.

Tested in multiplayer by using recharged oxygen tanks with a custom recipe with no observable issues.

Note: this is inside the current unstable build 0.19.1.0