Add type equality checks and overrides #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All classes implement IEquatable and have GetHashCode and Equals overrides.
Turnerj
added
the
enhancement
String can't override `JsonLdContext` and it also doesn't need the override.
Turnerj
changed the title
RehanSaeed
reviewed
Dec 16, 2019
Owner
RehanSaeed
left a comment
RehanSaeed
left a comment
There was a problem hiding this comment.
This is a good idea. I've wanted to do this but not had time. A few review comments.
Owner
|
Cool thanks. We should bump the version. If we get some of your other changes in, it'd be a major version upgrade. |
Collaborator
Author
|
Yeah - if we can my overhaul of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All classes implement IEquatable and have GetHashCode and Equals overrides. Not sure if it is worth adding the operator overloads for equality too.