Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlockArray.getAllDroppedItems & ProgressiveRecursiveBreaker doesn't call Forge HarvestDropsEvent #387

Closed
squeek502 opened this issue Nov 10, 2015 · 4 comments

Comments

@squeek502
Copy link

Forge provides an event (HarvestDropsEvent) that allows modification of the drops of a harvested block. See this function and where it is called in Minecraft code.

To add support for this event to BlockArray and classes that extend from it (like TreeReader), you'd need to add a ForgeEventFactory.fireBlockHarvesting call after this Block.getDrops call in BlockArray.getAllDroppedItems, which would also mean that the player would need to be passed to getAllDroppedItems.

Related: bspkrs/Treecapitator#33 and squeek502/VeganOption#30

@squeek502 squeek502 changed the title BlockArray.getAllDroppedItems doesn't call Forge HarvestBlockEvent BlockArray.getAllDroppedItems doesn't call Forge HarvestDropsEvent Nov 10, 2015
@ReikaKalseki
Copy link
Owner

That can probably be done with little difficulty.

@ReikaKalseki ReikaKalseki changed the title BlockArray.getAllDroppedItems doesn't call Forge HarvestDropsEvent BlockArray.getAllDroppedItems & ProgressiveRecursiveBreaker doesn't call Forge HarvestDropsEvent Nov 11, 2015
@ReikaKalseki
Copy link
Owner

Fixed.

@ghost
Copy link

ghost commented Nov 30, 2015

This pleases me. ;)

@squeek502
Copy link
Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants