-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minetweaker for Grinder #26
Conversation
|
I am going to tweak this a bit (no pun intended :P) but I will add it for the next version. |
|
How do I get all the MT class dependencies? Also, it looks like this code is broken: getItemStack() does not exist, and if it calls getStack() it overflows. |
|
https://github.com/ReikaKalseki/RotaryCraft/pull/26/files#diff-ee9feed29468d1da1ae8b67c1f82a344R3 should have taken care of the import |
|
OK, the code is included. |
|
It does not seem to be working - MT throws a "cannot find mods.rotarycraft" error. |
|
did you register it with the MT API? MineTweakerAPI.registerClass(XXXX.class); |
|
Yes. |
|
Minetweaker logs the following error whenever a Rotarycraft method is used: http://pastebin.com/HeEaqcQx. Time to investigate! |
|
That is not the same error I get. I get literally "cannot find mods.rotarycraft". |
|
can you post your Minetweaker script? both @ReikaKalseki ad @coolsquid |
|
I have also tried mods.rotarycraft.grinder, and rotarycraft.grinder. |
|
As far as i know Minetweaker is case-sensitive, it should be 'mods.rotarycraft.Grinder.addRecipe'. |
|
I will try this. EDIT: Still nothing: EDIT2: |
|
@ReikaKalseki - just checking, but you have done |
|
No...I had no idea that was necessary. I will try that when I get home in a few hours. |
|
|
Do imports here work anything like java? If so, adding an import for something I write the fully qualified name of is unnecessary, is it not? |
|
Yes, I just tried. |
|
So then there is another issue... |
|
@coolsquid - those aren't valid MT names - you need the <> around them @ReikaKalseki - I'll be around in a bit if you are free wanna get on IRC to discuss it |
|
I will be busy for the next few hours. |
|
Ok, send me a PM on IRC when you're about - I may be busy but if not I'll be happy to give you a hand |
|
Now I am. |
|
This apparently doesn't work, it literally can not find rotarycraft as part of mods member function. mods.rotarycraft.Grinder.addRecipe(minecraft:gravel, exnihilo:dust); |
|
Yes, I know. |
|
That's a shame, any idea why it's not in there? ...I came here looking to see if there was a way to remove Grinder recipes too. A lot of the defaults are way too generous IMO. Any chance of adding that in if/when you get this sorted? |
|
That is much less likely. |
|
Disappointing, but understandable. Thanks for the reply all the same. |
|
No longer necessary, as of v17. |

Added Minetweaker support for both Grinding recipes and seeds.
Recipes are stored in a different, editable HashMap, updated the relevant methods in RecipesGrinder
Checks for invalid output using the criteria defined in the Grinder API class, also checks for pre-existing recipe for that input. Input and output can be defined as either an OreDictionary entry (in which case it will add recipes for every entry that doesn't already exist for input, or the first OreDictionary entry for the output) or a specific ItemStack.
Seeds are added similarly to the seeds Map - but to protect against Canola being removed from the grinder a list of protected seeds is added - any seed on that list cannot be removed from the grindableSeed Map with the new removeGrindableSeed method
MinetweakerHelper class added to aid in MT input->ItemStacks. You might want to move this to DragonAPI at some point
Note: I had to write this outside of a dev environment - so it's very possible there are a couple of typos or missed imports you will have to clean up
Also didn't do any of the registering of the ZenClass (
MineTweakerAPI.registerClass(GrinderTweaker.class);) as I imagine this is something you'd want to centralise through DragonAPI - eg. a static function that you pass the classes to, checks MT is loaded, then does the registering if required.