Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upSlightly better way to toggle nogc #27
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Reisyukaku
Aug 4, 2018
Owner
That whole kippatch codebase triggers me and needs to be rewritten.. so I made the hacky patch for now. but yea that works lol
|
That whole kippatch codebase triggers me and needs to be rewritten.. so I made the hacky patch for now. but yea that works lol |
Reisyukaku
merged commit 1235dfa
into
Reisyukaku:master
Aug 4, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
fgsfdsfgs
Aug 4, 2018
Contributor
Understandable. Note that this shit changes the nogc "mechanics" and you now need to create a disable_nogc file to disable nogc. Don't even know if that's fine or you just didn't notice.
|
Understandable. Note that this shit changes the nogc "mechanics" and you now need to create a |
fgsfdsfgs commentedAug 4, 2018
I put
patchFilter[]in there for a reason, you know :^)Also I think it's better to leave it enabled by default, just in case someone forgets or doesn't know about the nogc file, since that could cause irreversible changes.