Skip *nix hidden files

[AnalogMan151]

Skips files with leading period for *nix and macOS

[Reisyukaku]

Only thing I'm concerned with is it assumes that those files are the last files in the list. Cant find where it says what order fatfs goes in

[Reisyukaku]

Only thing I'm concerned with is it assumes that those files are the last files in the list. Cant find where it says what order fatfs goes in

[AnalogMan151]

Ah, good point. It stops the loop as soon as it encounters a file leading with period. Hmmmmm... I'll retract the pull request until I figure it out.

[AnalogMan151]

Ah, good point. It stops the loop as soon as it encounters a file leading with period. Hmmmmm... I'll retract the pull request until I figure it out.

[AnalogMan151]

Tested this out and it appears to work but I would like your opinion:

    int i = 0; 
    while (fno.fname[0] != 0 && fr == FR_OK) {
        if (fno.fname[0] == '.') {
            f_findnext(&dp, &fno);
            continue;
        }   
        out = (char **)realloc(out, (i+1) * sizeof(char *));
        out[i] = (char *)malloc(FF_LFN_BUF);
        strcpy(out[i], pathb);
        strcat(out[i], fno.fname);
        pathb[pathlen+1] = 0;
        f_findnext(&dp, &fno);
        i++;
    }

Here is the file list in my sys modules folder:

._FS.kip
._loader.kip
._sm.kip
FS.kip
loader.kip
sm.kip

Without the edit my Switch will stall on launching when those files are encountered.

[AnalogMan151]

Tested this out and it appears to work but I would like your opinion:

    int i = 0; 
    while (fno.fname[0] != 0 && fr == FR_OK) {
        if (fno.fname[0] == '.') {
            f_findnext(&dp, &fno);
            continue;
        }   
        out = (char **)realloc(out, (i+1) * sizeof(char *));
        out[i] = (char *)malloc(FF_LFN_BUF);
        strcpy(out[i], pathb);
        strcat(out[i], fno.fname);
        pathb[pathlen+1] = 0;
        f_findnext(&dp, &fno);
        i++;
    }

Here is the file list in my sys modules folder:

._FS.kip
._loader.kip
._sm.kip
FS.kip
loader.kip
sm.kip

Without the edit my Switch will stall on launching when those files are encountered.

[Reisyukaku]

if (fno.fname[0] == '.') continue;
should work just fine i'd think

[Reisyukaku]

if (fno.fname[0] == '.') continue;
should work just fine i'd think

[AnalogMan151]

I thought that too but that increments i and also does not advance the fno.fname to the next entry (meaning it would just process the same filename over and over). If you did advance to next fno.fname with i incrementing it would leave empty out[] entries when it runs into one of the hidden files. With the while loop i is only incremented when a non-hidden file is found.

[AnalogMan151]

I thought that too but that increments i and also does not advance the fno.fname to the next entry (meaning it would just process the same filename over and over). If you did advance to next fno.fname with i incrementing it would leave empty out[] entries when it runs into one of the hidden files. With the while loop i is only incremented when a non-hidden file is found.

[Reisyukaku]

Ah right, in that case maybe this would be cleaner:

int i = 0; 
    while (fno.fname[0] != 0 && fr == FR_OK) {
        if (fno.fname[0] == '.') goto end;  
        out = (char **)realloc(out, (i+1) * sizeof(char *));
        out[i] = (char *)malloc(FF_LFN_BUF);
        strcpy(out[i], pathb);
        strcat(out[i], fno.fname);
        pathb[pathlen+1] = 0;

       end:
        f_findnext(&dp, &fno);
        i++;
    }

[Reisyukaku]

Ah right, in that case maybe this would be cleaner:

int i = 0; 
    while (fno.fname[0] != 0 && fr == FR_OK) {
        if (fno.fname[0] == '.') goto end;  
        out = (char **)realloc(out, (i+1) * sizeof(char *));
        out[i] = (char *)malloc(FF_LFN_BUF);
        strcpy(out[i], pathb);
        strcat(out[i], fno.fname);
        pathb[pathlen+1] = 0;

       end:
        f_findnext(&dp, &fno);
        i++;
    }

[AnalogMan151]

That still increments i when a hidden file is processed leaving an empty entry in the array. This perhaps?

int i = 0; 
    while (fno.fname[0] != 0 && fr == FR_OK) {
        if (fno.fname[0] == '.') goto end;  
        out = (char **)realloc(out, (i+1) * sizeof(char *));
        out[i] = (char *)malloc(FF_LFN_BUF);
        strcpy(out[i], pathb);
        strcat(out[i], fno.fname);
        pathb[pathlen+1] = 0;
        i++;
       end:
        f_findnext(&dp, &fno);
    }

[AnalogMan151]

That still increments i when a hidden file is processed leaving an empty entry in the array. This perhaps?

int i = 0; 
    while (fno.fname[0] != 0 && fr == FR_OK) {
        if (fno.fname[0] == '.') goto end;  
        out = (char **)realloc(out, (i+1) * sizeof(char *));
        out[i] = (char *)malloc(FF_LFN_BUF);
        strcpy(out[i], pathb);
        strcat(out[i], fno.fname);
        pathb[pathlen+1] = 0;
        i++;
       end:
        f_findnext(&dp, &fno);
    }

[Reisyukaku]

Oh derp. Didnt fully read. Yea, that looks good.

[Reisyukaku]

Oh derp. Didnt fully read. Yea, that looks good.

[AnalogMan151]

Fix added to pul request.

[AnalogMan151]

Fix added to pul request.