Skip to content

Add Base.propertynames() for all types that define getproperty() #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2022
Merged

Add Base.propertynames() for all types that define getproperty() #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions src/results.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,16 @@ _data(result::TransactionResult) = getfield(result, :_data)

Base.getindex(result::TransactionResult, key) = _data(result)[key]

function Base.propertynames(result::TransactionResult, private::Bool=false)
data = _data(result)
names = (keys(data)..., :relations)
if private
names = (names..., fieldnames(TransactionResult)...)
end
return names
end
function Base.getproperty(result::TransactionResult, name::Symbol)
name in fieldnames(TransactionResult) && return getfield(result, name)
data = _data(result)
name == :relations && return Relations(data.output)
return data[name]
Expand Down Expand Up @@ -148,7 +157,16 @@ end
Base.eltype(::Relation) = RelRow
Base.getindex(relation::Relation, key::Int) = getrow(relation, key)

function Base.propertynames(relation::Relation, private::Bool=false)
data = _data(relation)
names = (keys(data)..., :name)
if private
names = (names..., fieldnames(Relation)...)
end
return names
end
function Base.getproperty(relation::Relation, name::Symbol)
name in fieldnames(Relation) && return getfield(result, name)
data = _data(relation)
name == :name && return data.rel_key.name
return _data(relation)[name]
Expand Down Expand Up @@ -247,6 +265,9 @@ _indexof(row, name) = findfirst(==(name), _names(row))

Base.getindex(row::RelRow, key::Int) = _values(row)[key]

function Base.propertynames(row::RelRow)
return (_names(row)..., fieldnames(RelRow))
end
function Base.getproperty(row::RelRow, name::Symbol)
name in _names(row) && return getcolumn(row, name)
return getfield(row, name)
Expand Down