Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/pro-1286-fit_predict_update-vs #469

Merged
merged 15 commits into from Feb 27, 2022

Conversation

ofrighil
Copy link
Contributor

No description provided.

@ofrighil ofrighil changed the title [WIP] feature/pro-1286-fit_predict_update-vs feature/pro-1286-fit_predict_update-vs Feb 17, 2022
@boba-and-beer boba-and-beer merged commit d0d7cf0 into development Feb 27, 2022
@linear
Copy link

linear bot commented Feb 27, 2022

PRO-1286 fit_predict_update vs fit_predict_documents argument for fit_update

anticipate common mistakes, low cognitive load

tbh i still don't really know or can't tell what fit_predict_documents do.

I still strongly think you should consider:

fit_predict_update → fit_update

with recommended flow being:

cluster_ops.fit_predict(df, ...)
cluster_ops.update()

fit_predict_documents →

cluster_ops.fit_predict(docs, ...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants