Skip to content

Add shader search scopes for assembly keyword filtering#114

Merged
cobalticarus92 merged 1 commit into
shadersfrom
codex/add-keyword-search-in-shader-tab
Feb 25, 2026
Merged

Add shader search scopes for assembly keyword filtering#114
cobalticarus92 merged 1 commit into
shadersfrom
codex/add-keyword-search-in-shader-tab

Conversation

@cobalticarus92

@cobalticarus92 cobalticarus92 commented Feb 25, 2026

Copy link
Copy Markdown
Collaborator

Motivation

  • Shader tab filter should search for keywords not just in list labels but also across captured shader assemblies or the currently selected shader assembly.

Description

  • Added a new enum ShaderSearchScopeMode and global g_shaderSearchScopeMode to track the selected search scope.
  • Exposed a Search scope combo in the Shader tab UI and adjusted layout widths so the scope selector sits next to the existing Filter and Order controls.
  • Implemented a case-insensitive helper ContainsCaseInsensitive and updated the shader list filtering to optionally check rec.cachedDisassembly and rec.editableAssembly when All shader assemblies or Selected shader assembly is chosen.
  • Kept existing behavior as the default by treating List labels as the label-only match mode and integrated the new logic alongside the existing label filtering.

Testing

  • Ran git diff --check to validate the patch formatting and it completed without errors.
  • Ran git status --short to verify the modified file presence in the working tree.
  • No compilation or runtime shader tests were executed as part of this change in this PR.

Codex Task

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 763e639c94

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread d3d9_proxy.cpp
@cobalticarus92 cobalticarus92 merged commit ea2c4c4 into shaders Feb 25, 2026
@cobalticarus92 cobalticarus92 deleted the codex/add-keyword-search-in-shader-tab branch February 25, 2026 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant