Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method to get JsonNode with internal $ref pointers deferenced #43

Closed
wants to merge 5 commits into from

Conversation

slinkydeveloper
Copy link
Contributor

For more informations: #4

For more informations check out GettingStarted.md diff of this commit
@slinkydeveloper
Copy link
Contributor Author

Why you can't accept this PR?

@andylowry
Copy link
Contributor

@slinkydeveloper I've reviewed this code, but I chose to go with a very different approach - much more in line with the advice I offered when you started this work. Please take a look at #4 and #82 for details.

I believe that what you were after is obtainable with model.toJson(true) (or more generally, obj.toJson(true), where obj could be a Schema or a Path or any other ObjectOverlay extension). The boolean param indicates whether embedded references should be followed (true) or appear as references in the result (false).

I'll close this PR at this point, but I appreciate your contributions, and I trust that your forked code was able to support your summer work, despite my unavailability. At this point, I believe/hope that master branch will support your needs.

@andylowry andylowry closed this Sep 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants